[Mapnik] new port by mathisloge · Pull Request #18849 · microsoft/vcpkg

mathisloge · 2021-07-07T08:56:53Z

Describe the pull request
adds mapnik without forking the mapnik repository. However, this PR needs the current master.

~~Adds the mapbox-geometry and mapbox-polyline ports.~~ (added in #16838).

What does your PR fix?
Fixes [New Port Request] <Mapnik> #7526
Since i have screwed up the previous PR [Mapnik] new port #14628 i've done this one again.
Which triplets are supported/not supported? Have you updated the CI baseline?
needs CI test
Does your PR follow the maintainer guide? yes

todo

update REPO and REF to mapnik repo when upstream was merged
wait for CMake build support mapnik/mapnik#4191 to be merged

…ik-two

JonLiu1993 · 2021-07-26T06:26:33Z

@mathisloge ,If this pr is ready for review, please turn to open state

mathisloge · 2021-07-26T06:33:56Z

@mathisloge ,If this pr is ready for review, please turn to open state

Yes. Might take some time until upstream gets merged.

…ik-two

mathisloge · 2021-09-14T12:15:29Z

standalone mapnik demo which tests the most common functionalities

plugin loading
file reading
map rendering with fonts

https://github.com/mathisloge/mapnik-vcpkg-test

…ik-two

mathisloge · 2021-09-15T16:19:33Z

updated to latest commit. It adds mapnik::core as a public dependency of mapnik::mapnik. Changed the usage a bit

…ik-two

BillyONeal · 2021-09-15T18:41:49Z

/azp run

azure-pipelines · 2021-09-15T18:41:58Z

Azure Pipelines successfully started running 1 pipeline(s).

BillyONeal · 2021-09-15T18:42:25Z

Sorry for the CI failures, we backed out the check that caused everything to fail for the last 10 hours or so

…ik-two

dg0yt · 2021-09-16T07:24:57Z

@mathisloge For a more convenient CI trigger:

git commit --allow-empty -m "[skip actions] Trigger CI"
git push

NancyLi1013 · 2021-09-16T08:14:36Z

LGTM now, thanks for your efforts. It's has taken so long time on this port. @mathisloge

mathisloge · 2021-09-16T08:27:11Z

@NancyLi1013 thanks for your reviews!
It was indeed a very long time but it has also contributed a lot to upstream (windows support and a far easier setup to build upstream itself)

BillyONeal · 2021-09-16T23:16:24Z

Thanks for the new port!

mathisloge added 2 commits July 7, 2021 10:55

add mapnik

6f1ff9c

version

5e7bb2a

This was referenced Jul 7, 2021

[Mapnik] new port #14628

Closed

Enable all platforms again mapnik/node-mapnik#976

Draft

JonLiu1993 self-assigned this Jul 7, 2021

JonLiu1993 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Jul 7, 2021

mathisloge added 5 commits July 7, 2021 21:09

update to latest ref

1348c60

overwrite version

cd89f3a

latest ref

6dbca1e

fix hash

b32be8a

verison

b7d64d9

NancyLi1013 added the depends:upstream-changes Waiting on a change to the upstream project label Jul 8, 2021

mathisloge added 11 commits July 9, 2021 11:45

Merge branch 'master' of https://github.com/microsoft/vcpkg into mapn…

6fbac07

…ik-two

Merge branch 'master' of https://github.com/microsoft/vcpkg into mapn…

cb042ae

…ik-two

Merge branch 'master' of https://github.com/microsoft/vcpkg into mapn…

dff6bcd

…ik-two

update to latest upstream

042dd27

version

478f1b3

false jpeg lib

4d15711

version

033b3bb

Merge branch 'master' of https://github.com/microsoft/vcpkg into mapn…

bd0c356

…ik-two

Merge branch 'master' of https://github.com/microsoft/vcpkg into mapn…

7289bfb

…ik-two

update to latest ref

e46b87a

verssion

5d67a86

mathisloge mentioned this pull request Jul 23, 2021

[gdal] Fix build for non-Windows targets #17698

Merged

Merge branch 'master' of https://github.com/microsoft/vcpkg into mapn…

7334c86

…ik-two

mathisloge added 2 commits July 26, 2021 20:20

Merge branch 'master' of https://github.com/microsoft/vcpkg into mapn…

7a39a4f

…ik-two

Merge branch 'master' of https://github.com/microsoft/vcpkg into mapn…

a176918

…ik-two

github-actions bot approved these changes Jul 31, 2021

View reviewed changes

Merge branch 'master' of https://github.com/microsoft/vcpkg into mapn…

97c51a6

…ik-two

github-actions bot approved these changes Sep 14, 2021

View reviewed changes

mathisloge added 2 commits September 15, 2021 18:18

drop mapnik::core from general usage info.

34ae59e

version

40c2b38

github-actions bot approved these changes Sep 15, 2021

View reviewed changes

Merge branch 'master' of https://github.com/microsoft/vcpkg into mapn…

f358550

…ik-two

github-actions bot approved these changes Sep 15, 2021

View reviewed changes

don't add a new version

025ae88

github-actions bot approved these changes Sep 15, 2021

View reviewed changes

Merge branch 'master' of https://github.com/microsoft/vcpkg into mapn…

4ffddec

…ik-two

github-actions bot approved these changes Sep 15, 2021

View reviewed changes

mathisloge added 2 commits September 16, 2021 08:55

add comment to trigger ci

f131f36

version

f193b62

github-actions bot approved these changes Sep 16, 2021

View reviewed changes

mathisloge requested a review from NancyLi1013 September 16, 2021 08:00

NancyLi1013 approved these changes Sep 16, 2021

View reviewed changes

NancyLi1013 added info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. and removed requires:author-response labels Sep 16, 2021

BillyONeal merged commit c26101d into microsoft:master Sep 16, 2021

mathisloge deleted the mapnik-two branch September 17, 2021 06:30

mathisloge mentioned this pull request Mar 29, 2022

Make it available as vcpkg package DiligentGraphics/DiligentEngine#40

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Mapnik] new port#18849

[Mapnik] new port#18849
BillyONeal merged 50 commits intomicrosoft:masterfrom
mathisloge:mapnik-two

mathisloge commented Jul 7, 2021 •

edited

Loading

Uh oh!

JonLiu1993 commented Jul 26, 2021

Uh oh!

mathisloge commented Jul 26, 2021

Uh oh!

mathisloge commented Sep 14, 2021 •

edited

Loading

Uh oh!

mathisloge commented Sep 15, 2021 •

edited

Loading

Uh oh!

BillyONeal commented Sep 15, 2021

Uh oh!

azure-pipelines bot commented Sep 15, 2021

Uh oh!

BillyONeal commented Sep 15, 2021

Uh oh!

dg0yt commented Sep 16, 2021

Uh oh!

NancyLi1013 commented Sep 16, 2021

Uh oh!

mathisloge commented Sep 16, 2021

Uh oh!

BillyONeal commented Sep 16, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

mathisloge commented Jul 7, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

todo

Uh oh!

JonLiu1993 commented Jul 26, 2021

Uh oh!

mathisloge commented Jul 26, 2021

Uh oh!

mathisloge commented Sep 14, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mathisloge commented Sep 15, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

BillyONeal commented Sep 15, 2021

Uh oh!

azure-pipelines bot commented Sep 15, 2021

Uh oh!

BillyONeal commented Sep 15, 2021

Uh oh!

dg0yt commented Sep 16, 2021

Uh oh!

NancyLi1013 commented Sep 16, 2021

Uh oh!

mathisloge commented Sep 16, 2021

Uh oh!

BillyONeal commented Sep 16, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

mathisloge commented Jul 7, 2021 •

edited

Loading

mathisloge commented Sep 14, 2021 •

edited

Loading

mathisloge commented Sep 15, 2021 •

edited

Loading