Skip to content

[CGAL] Upgrade to 5.3#18392

Merged
vicroms merged 13 commits intomicrosoft:masterfrom
maxGimeno:CGAL-Upgrade_to_5.3-maxGimeno
Jul 26, 2021
Merged

[CGAL] Upgrade to 5.3#18392
vicroms merged 13 commits intomicrosoft:masterfrom
maxGimeno:CGAL-Upgrade_to_5.3-maxGimeno

Conversation

@maxGimeno
Copy link
Copy Markdown
Contributor

@maxGimeno maxGimeno commented Jun 11, 2021

Upgrade CGAL to version 5.3

@maxGimeno maxGimeno mentioned this pull request Jun 11, 2021
Closed
70 tasks
@JonLiu1993 JonLiu1993 self-assigned this Jun 15, 2021
@JonLiu1993 JonLiu1993 added the category:port-update The issue is with a library, which is requesting update new revision label Jun 15, 2021
@JonLiu1993
Copy link
Copy Markdown
Contributor

JonLiu1993 commented Jun 15, 2021

@maxGimeno ,Thanks for your contribution.
upgrade to the 5.3-beta1 pre-release version, our policy is not recommended, because the pre-release version is unstable and there may be many problems

@maxGimeno
Copy link
Copy Markdown
Contributor Author

maxGimeno commented Jun 15, 2021

@JonLiu1993 don't worry, it will stay a draft until the release of the CGAL 5.3 version, then I'll update the PR to the stable version and un-draft it. For now it was just to be sure that in the current state we can pass your CI.

@maxGimeno maxGimeno marked this pull request as ready for review July 6, 2021 13:37
@JonLiu1993 JonLiu1993 changed the title CGAL: Upgrade to 5.3 [CGAL] Upgrade to 5.3 Jul 7, 2021
JonLiu1993
JonLiu1993 suggested changes Jul 7, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@JonLiu1993 JonLiu1993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add 'FEATURES' in function vcpkg_check_features like:

vcpkg_check_features(OUT_FEATURE_OPTIONS FEATURE_OPTIONS
    FEATURES
    qt WITH_CGAL_Qt5
)

@JonLiu1993
Copy link
Copy Markdown
Contributor

JonLiu1993 commented Jul 7, 2021

@maxGimeno ,After completing the modification, please run the command "./vcpkg x-add-version cgal --overwrite-version", and then submit the changes again.

@JonLiu1993 JonLiu1993 added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Jul 8, 2021
ras0219-msft
ras0219-msft approved these changes Jul 8, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@ras0219-msft ras0219-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@JonLiu1993 JonLiu1993 removed the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Jul 12, 2021
@JonLiu1993
Copy link
Copy Markdown
Contributor

JonLiu1993 commented Jul 14, 2021

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Jul 14, 2021

Azure Pipelines successfully started running 1 pipeline(s).

@PhoebeHui PhoebeHui added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Jul 16, 2021
vicroms
vicroms approved these changes Jul 23, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@vicroms vicroms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve merge conglicts, otherwise LGTM.

JonLiu1993
JonLiu1993 suggested changes Jul 23, 2021
View reviewed changes
@JonLiu1993 JonLiu1993 added requires:author-response and removed info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. labels Jul 23, 2021
@JonLiu1993 JonLiu1993 added info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. and removed requires:author-response labels Jul 26, 2021
@vicroms vicroms merged commit f232529 into microsoft:master Jul 26, 2021
@lrineau lrineau deleted the CGAL-Upgrade_to_5.3-maxGimeno branch July 27, 2021 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vicroms vicroms vicroms approved these changes

+3 more reviewers

@ras0219-msft ras0219-msft ras0219-msft approved these changes

@PhoebeHui PhoebeHui PhoebeHui approved these changes

@JonLiu1993 JonLiu1993 JonLiu1993 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@JonLiu1993 JonLiu1993

Labels

category:port-update The issue is with a library, which is requesting update new revision info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@maxGimeno @JonLiu1993 @vicroms @ras0219-msft @PhoebeHui @BillyONeal