You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
That's true, but I think for the purposes of local development it is not a burden to require use of the literal 0 (esp. compared with the burden of synthesizing exactly 128 0's). Most importantly, the error messages should make the path forward clear.
That's true, but I think for the purposes of local development it is not a burden to require use of the literal 0 (esp. compared with the burden of synthesizing exactly 128 0's).
The code to fill up the hash with zeros up to a string length of 128 was not that complicated.
Most importantly, the error messages should make the path forward clear.
No, it only shows that I have entered an invalid sha, e.g. for the input 1. Imho not very user friendly. Imho it should just do it like in your first version, it is the easiest one for the users.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
category:vcpkg-featureThe issue is a new capability of the tool that doesn’t already exist and we haven’t committed
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.