Skip to content

[tiff] Update to 4.3.0, improvements#18187

Merged
strega-nil-ms merged 18 commits intomicrosoft:masterfrom
dg0yt:tiff
Jun 9, 2021
Merged

[tiff] Update to 4.3.0, improvements#18187
strega-nil-ms merged 18 commits intomicrosoft:masterfrom
dg0yt:tiff

Conversation

@dg0yt
Copy link
Copy Markdown
Contributor

@dg0yt dg0yt commented May 29, 2021 •
edited
Loading

  • What does your PR fix?

  • Important change in libtiff 4.3.0

    Use of "int8", "uint8", "int16", "uint16", "int32", "uint32", "int64", "uint64" typedefs is now deprecated. libtiff code and headers no longer use them, and use their C99 standard equivalents (with "_t" suffix). Those typedefs are still available, with deprecation warnings, but external code is strongly encouraged to use the corresponding C99 stdint.h types. The deprecated types might be removed in a future release.

    (From https://libtiff.gitlab.io/libtiff/v4.3.0.html#libtiff)
    This affects at least port selene which treated these warnings as errors.

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    all, no

  • Does your PR follow the maintainer guide?

    yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    I am still working on this PR.

@dg0yt dg0yt mentioned this pull request May 29, 2021
Closed
@dg0yt dg0yt force-pushed the tiff branch 3 times, most recently from 05676b4 to 90b4e5c Compare May 29, 2021 15:06
cenit
cenit reviewed May 29, 2021
View reviewed changes
@dg0yt dg0yt force-pushed the tiff branch 3 times, most recently from 82d33ca to e0f0ac7 Compare May 30, 2021 08:02
@dg0yt
Copy link
Copy Markdown
Contributor Author

dg0yt commented May 30, 2021

Manually tested, covering the cmake wrapper:
tiff[cxx,jpeg,lzma,tools,webp,zip,zstd]:x64-linux + libgeotiff:x64-linux

@dg0yt dg0yt marked this pull request as ready for review May 30, 2021 13:03
@dg0yt dg0yt marked this pull request as draft May 30, 2021 13:15
@dg0yt dg0yt marked this pull request as ready for review May 30, 2021 13:20
@JonLiu1993 JonLiu1993 self-assigned this May 31, 2021
@JonLiu1993 JonLiu1993 added the category:port-update The issue is with a library, which is requesting update new revision label May 31, 2021
JonLiu1993
JonLiu1993 suggested changes May 31, 2021
View reviewed changes
@dg0yt dg0yt requested a review from JonLiu1993 May 31, 2021 19:19
JackBoosY
JackBoosY approved these changes Jun 1, 2021
View reviewed changes
@JackBoosY JackBoosY added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Jun 1, 2021
cenit
cenit reviewed Jun 1, 2021
View reviewed changes
@JonLiu1993
Copy link
Copy Markdown
Contributor

JonLiu1993 commented Jun 2, 2021 •
edited
Loading

All features are tested successfully in the following triplets:

  • x86-windows
  • x64-windows
  • x64-windows-static
  • x64-linux

@JonLiu1993 JonLiu1993 added info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. and removed requires:all-feature-testing labels Jun 2, 2021
ras0219-msft
ras0219-msft approved these changes Jun 3, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@ras0219-msft ras0219-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the update!

@strega-nil-ms
Copy link
Copy Markdown
Contributor

strega-nil-ms commented Jun 9, 2021

LGTM, thanks @dg0yt :)

@strega-nil-ms strega-nil-ms merged commit 40ad15c into microsoft:master Jun 9, 2021
@dg0yt dg0yt mentioned this pull request Jun 15, 2021
Closed
@dg0yt dg0yt deleted the tiff branch June 17, 2021 17:00
@dg0yt dg0yt mentioned this pull request Aug 10, 2021
Merged
@AbdulAbCellera
Copy link
Copy Markdown

AbdulAbCellera commented Nov 27, 2022 •
edited
Loading

Hi, I have a question about CXX feature support on arm.

I want to compile with the CXX feature for Apple M1 (arm64). So I did the following:

  • I removed "supports" : !arm
  • I added the cxx feature to vcpkg.json
  • I linked my targets to TIFF::CXX
  • I compiled

These changes do not seem to have any issues.

The question is what is the best approach to get this support natively?
Do I have to link to another target?
or post a PR for arm64 support of CXX feature?

@dg0yt
Copy link
Copy Markdown
Contributor Author

dg0yt commented Nov 27, 2022

I guess this particular arm restriction is obsolete. The next PR can remove the supports line from this feature. In the mean time you may also install tiff[cxx] with --allow-unsupported.

@AbdulAbCellera
Copy link
Copy Markdown

AbdulAbCellera commented Nov 27, 2022

Is there a way to set --allow-unsupported in manifest mode?

@dg0yt
Copy link
Copy Markdown
Contributor Author

dg0yt commented Nov 27, 2022 •
edited
Loading

Is there a way to set --allow-unsupported in manifest mode?

Yes, just pass is through with CMAKE_INSTALL_OPTIONSVCPKG_INSTALL_OPTIONS :
https://github.com/microsoft/vcpkg/blob/master/docs/users/buildsystems/cmake-integration.md#vcpkg_install_options

@AbdulAbCellera
Copy link
Copy Markdown

AbdulAbCellera commented Dec 20, 2022 •
edited
Loading

I think you meant VCPKG_INSTALL_OPTIONS instead of CMAKE_INSTALL_OPTIONS :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

4 more reviewers

@cenit cenit cenit approved these changes

@ras0219-msft ras0219-msft ras0219-msft approved these changes

@JackBoosY JackBoosY JackBoosY approved these changes

@JonLiu1993 JonLiu1993 JonLiu1993 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@JonLiu1993 JonLiu1993

Labels

category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist category:port-update The issue is with a library, which is requesting update new revision info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[tiff] update to 4.3.0 [tiff] Installed pkg-config (.pc) debug files specify non-existent includedir

7 participants

@dg0yt @JonLiu1993 @strega-nil-ms @AbdulAbCellera @cenit @ras0219-msft @JackBoosY