Skip to content

[icu] fix mingw builds#18175

Closed
autoantwort wants to merge 1 commit intomicrosoft:masterfrom
autoantwort:icu-mingw
Closed

[icu] fix mingw builds#18175
autoantwort wants to merge 1 commit intomicrosoft:masterfrom
autoantwort:icu-mingw

Conversation

@autoantwort
Copy link
Copy Markdown
Contributor

@autoantwort autoantwort commented May 28, 2021

Describe the pull request

  • What does your PR fix?

    Fixes [icu] mingw build failure #16663

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    All, no

  • Does your PR follow the maintainer guide?

    Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    Yes

@longnguyen2004
Copy link
Copy Markdown
Contributor

longnguyen2004 commented May 30, 2021 •
edited
Loading

Can you remove the first commit from this PR? I believe you might have mistakenly added it here.
Also, please update the version file. It got lost in the first commit, please fix that.

longnguyen2004
longnguyen2004 reviewed May 30, 2021
View reviewed changes
@JackBoosY JackBoosY added the category:community-triplet A PR or issue related to community triplets not officially validated by the vcpkg team. label May 31, 2021
JackBoosY
JackBoosY suggested changes May 31, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@JackBoosY JackBoosY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR contains some source changes, does the upstream approve it?

@longnguyen2004
Copy link
Copy Markdown
Contributor

longnguyen2004 commented May 31, 2021

It was taken from unicode-org/icu#1733

@JackBoosY
Copy link
Copy Markdown
Contributor

JackBoosY commented May 31, 2021

It was taken from unicode-org/icu#1733

So lets wait for unicode-org/icu#1733 merge.

@JackBoosY JackBoosY added depends:upstream-changes Waiting on a change to the upstream project and removed requires:author-response labels May 31, 2021
@autoantwort autoantwort force-pushed the icu-mingw branch 2 times, most recently from efd645e to 570e1dc Compare July 12, 2021 18:15
@dg0yt dg0yt mentioned this pull request Sep 19, 2021
Merged
@PhoebeHui
Copy link
Copy Markdown
Contributor

PhoebeHui commented Sep 22, 2021

Closing in favor of #20253.

@PhoebeHui PhoebeHui closed this Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

+2 more reviewers

@longnguyen2004 longnguyen2004 longnguyen2004 left review comments

@JackBoosY JackBoosY JackBoosY requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@JackBoosY JackBoosY

Labels

category:community-triplet A PR or issue related to community triplets not officially validated by the vcpkg team. depends:upstream-changes Waiting on a change to the upstream project

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[icu] mingw build failure

4 participants

@autoantwort @longnguyen2004 @JackBoosY @PhoebeHui