Revert "[vcpkg.cmake] fix Neumann-A problem with find_package (#17955)"#17991
Merged
strega-nil-ms merged 1 commit intomicrosoft:masterfrom May 18, 2021
Merged
Revert "[vcpkg.cmake] fix Neumann-A problem with find_package (#17955)"#17991strega-nil-ms merged 1 commit intomicrosoft:masterfrom
strega-nil-ms merged 1 commit intomicrosoft:masterfrom
Conversation
…oft#17955)" This reverts commit b369b11. This change broke opencv, and it was not noticed since vcpkg.cmake didn't rebuild the world.
This was referenced May 18, 2021
Contributor
|
I'm curious why it broke opencv4. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit b369b11.
This change broke opencv, and it was not noticed since vcpkg.cmake
didn't rebuild the world.
Describe the pull request
What does your PR fix?
Fixes #...
Which triplets are supported/not supported? Have you updated the CI baseline?
<all / linux, windows, ...>, <Yes/No>
Does your PR follow the maintainer guide?
Your answerIf you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?<Yes / I am still working on this PR>
If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/