Skip to content

Fix handling of empty fields in vcpkg_fixup_pkgconfig#17898

Merged
ras0219-msft merged 1 commit intomicrosoft:masterfrom
dg0yt:pkgconfig
May 24, 2021
Merged

Fix handling of empty fields in vcpkg_fixup_pkgconfig#17898
ras0219-msft merged 1 commit intomicrosoft:masterfrom
dg0yt:pkgconfig

Conversation

@dg0yt
Copy link
Copy Markdown
Contributor

@dg0yt dg0yt commented May 13, 2021

Describe the pull request

  • What does your PR fix?

    Input pc file (example: port libmicrohttpd):

    Requires:
Requires.private:

    Broken output:

    Requires:
Requires:

    Fixed output:

    Requires:

    Similar for Libs

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    all, no

  • Does your PR follow the maintainer guide?

    yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    -/-

@dg0yt dg0yt mentioned this pull request May 13, 2021
Merged
@JackBoosY JackBoosY added the category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly label May 14, 2021
@JackBoosY
Copy link
Copy Markdown
Contributor

JackBoosY commented May 14, 2021

LGTM, @Neumann-A what do you think about this?

@JackBoosY JackBoosY added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label May 15, 2021
@ras0219-msft ras0219-msft merged commit 43ae0c9 into microsoft:master May 24, 2021
@ras0219-msft
Copy link
Copy Markdown
Contributor

ras0219-msft commented May 24, 2021

This LGTM, thanks for the improvement!

@dg0yt dg0yt deleted the pkgconfig branch May 27, 2021 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@JackBoosY JackBoosY JackBoosY approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@JackBoosY JackBoosY

Labels

category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dg0yt @JackBoosY @ras0219-msft