Strip "-l" suffix before removing "uuid" from libraries#17780
Closed
375gnu wants to merge 1 commit intomicrosoft:masterfrom
Closed
Strip "-l" suffix before removing "uuid" from libraries#17780375gnu wants to merge 1 commit intomicrosoft:masterfrom
375gnu wants to merge 1 commit intomicrosoft:masterfrom
Conversation
Contributor
|
cc @longnguyen2004 @Neumann-A for review this PR. |
Contributor
|
It's pretty much the same as what I did in #17769, so LGTM. |
longnguyen2004
approved these changes
May 11, 2021
Contributor
|
This changes is same with PR #17137, so I think we should use the old one. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the pull request
My builds using mingw64 were failing due to missing
libuuidwhile it's supposed that on windows it's removed from a list of libraries. The problem is that when the removal is invokedALL_LIBS_LISTcontains names with-lsuffix so the actual value is-luuidand it's not removed. This small change fixes this issue.