Add arm64-osx-dynamic triplet#17363
Conversation
|
I'm marking this requires: discussion because to my understanding this could be bad for the same reason we don't provide dynamic linux triplets, even under community; because we have no means of arranging for the loader to ever find the right libs. (getting into community means we have to not know it won't work) I do observe there already is an x64-osx-dynamic. Either:
|
|
Can't say I have deep knowledge in dynamic loading nor am I heavily invested either way for vcpkg; I only submitted this PR while testing vcpkg for a project and noticing there was no dynamic arm64 triplet. For my purposes, the games I build on macOS use dylibs for things like SDL2 which use I personally don't ever build and distribute non-bundled apps on macOS so that distribution channel might have more issues here, but I believe |
|
I see, so the bundling process fixes up rpath to be all relative within the bundle correctly? That is something meaningfully different than linux which argues to merge this. |
|
After a conversation with @strega-nil we're going to merge this. Thanks for your contribution! |
Describe the pull request
What does your PR fix?
Adds a new triplet for dynamic libraries for arm64 on osx. I copied the existing
arm64-osxtriplet and simply changedVCPKG_LIBRARY_LINKAGEtodynamic. I tested with./vcpkg install sdl2:arm64-osx-dynamicand it successfully built a.dylibinstead of a.a.Which triplets are supported/not supported? Have you updated the CI baseline?
N/A, this is just adding a new community triplet.
Does your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?N/A, not a change to any ports