Skip to content

[vcpkg baseline][marble] Disable find I18n#17341

Merged
strega-nil merged 2 commits intomicrosoft:masterfrom
JackBoosY:dev/jack/fix_baseline_20210418
Apr 20, 2021
Merged

[vcpkg baseline][marble] Disable find I18n#17341
strega-nil merged 2 commits intomicrosoft:masterfrom
JackBoosY:dev/jack/fix_baseline_20210418

Conversation

@JackBoosY
Copy link
Copy Markdown
Contributor

@JackBoosY JackBoosY commented Apr 18, 2021

Configure error when building marble:x64-windows on pipeline test:

CMake Error at D:/downloads/tools/cmake-3.19.2-windows/cmake-3.19.2-win32-x86/share/cmake-3.19/Modules/FindPackageHandleStandardArgs.cmake:218 (message):
  Could NOT find Gettext (missing: GETTEXT_MSGMERGE_EXECUTABLE
  GETTEXT_MSGFMT_EXECUTABLE)
Call Stack (most recent call first):
  D:/downloads/tools/cmake-3.19.2-windows/cmake-3.19.2-win32-x86/share/cmake-3.19/Modules/FindPackageHandleStandardArgs.cmake:582 (_FPHSA_FAILURE_MESSAGE)
  D:/downloads/tools/cmake-3.19.2-windows/cmake-3.19.2-win32-x86/share/cmake-3.19/Modules/FindGettext.cmake:81 (FIND_PACKAGE_HANDLE_STANDARD_ARGS)
  C:/a/1/s/scripts/buildsystems/vcpkg.cmake:861 (_find_package)
  D:/installed/x64-windows/share/kf5i18n/KF5I18nMacros.cmake:5 (find_package)
  D:/installed/x64-windows/share/kf5i18n/KF5I18nConfig.cmake:33 (include)
  C:/a/1/s/scripts/buildsystems/vcpkg.cmake:861 (_find_package)
  D:/installed/x64-windows/share/ECM/find-modules/FindKF5.cmake:53 (find_package)
  C:/a/1/s/scripts/buildsystems/vcpkg.cmake:861 (_find_package)
  MarbleMacros.cmake:124 (find_package)
  src/apps/marble-kde/CMakeLists.txt:14 (macro_optional_find_package)

Fixes #17340.

@JackBoosY JackBoosY added category:port-bug The issue is with a library, which is something the port should already support info:internal labels Apr 18, 2021
This was referenced Apr 18, 2021
Merged
Closed
@JackBoosY JackBoosY requested a review from PhoebeHui April 18, 2021 03:34
@PhoebeHui PhoebeHui added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Apr 19, 2021
@JackBoosY JackBoosY mentioned this pull request Apr 19, 2021
Merged
@strega-nil strega-nil merged commit 631177d into microsoft:master Apr 20, 2021
@JackBoosY JackBoosY deleted the dev/jack/fix_baseline_20210418 branch April 20, 2021 00:51
@JackBoosY JackBoosY mentioned this pull request Apr 25, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@PhoebeHui PhoebeHui PhoebeHui approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@PhoebeHui PhoebeHui

Labels

category:port-bug The issue is with a library, which is something the port should already support info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[marble] build failure on x64-windows

3 participants

@JackBoosY @PhoebeHui @strega-nil