Skip to content

[vcpkg/scripts/make] determine whether to use automake wrappers#17215

Merged
ras0219-msft merged 1 commit intomicrosoft:masterfrom
huangqinjin:automake-wrappers
May 26, 2021
Merged

[vcpkg/scripts/make] determine whether to use automake wrappers#17215
ras0219-msft merged 1 commit intomicrosoft:masterfrom
huangqinjin:automake-wrappers

Conversation

@huangqinjin
Copy link
Copy Markdown
Contributor

@huangqinjin huangqinjin commented Apr 11, 2021 •
edited
Loading

Using ar-lib to wrap GNU ar will result in error

ar: invalid option -- 'L'

Neumann-A
Neumann-A reviewed Apr 11, 2021
View reviewed changes
@dg0yt

This comment has been minimized.

Sign in to view
@huangqinjin
Copy link
Copy Markdown
Contributor Author

huangqinjin commented Apr 11, 2021

@dg0yt Once the PRs targeting Android get approved and merged, I would try to make CMAKE_HOST_WIN32-only parts to be common for all hosts to enable cross compiling. This PR is also prepared for that.

@JackBoosY JackBoosY added the category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly label Apr 12, 2021
@JackBoosY
Copy link
Copy Markdown
Contributor

JackBoosY commented Apr 12, 2021

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Apr 12, 2021

Azure Pipelines successfully started running 1 pipeline(s).

@dg0yt
Copy link
Copy Markdown
Contributor

dg0yt commented Apr 12, 2021

There is only libtasn1 and libidn2 failing now, on x64_osc, in the gtkdocize step while running autoconf. Confirmed to be fixed by brew install autoconf automake gtk-doc.

@dg0yt dg0yt mentioned this pull request Apr 12, 2021
Closed
@JackBoosY JackBoosY added the depends:different-pr This PR or Issue depends on a PR which has been filed label Apr 12, 2021
Neumann-A
Neumann-A reviewed Apr 12, 2021
View reviewed changes
Neumann-A
Neumann-A reviewed Apr 12, 2021
View reviewed changes
@dg0yt dg0yt mentioned this pull request Apr 14, 2021
Closed
@dg0yt
Copy link
Copy Markdown
Contributor

dg0yt commented May 2, 2021 •
edited
Loading

This is mandatory for mingw on linuxWindows. Merge conflict resolution proposed at huangqinjin#1. I hope it gets resolved before new conflicts arrive.

@dg0yt
Copy link
Copy Markdown
Contributor

dg0yt commented May 11, 2021

Ping. Blocker for mingw on Windows.

@wrobelda
Copy link
Copy Markdown
Contributor

wrobelda commented May 19, 2021

Seems that the issue I am having with Windows support for libtasn1 is related: #16953 (comment)

@dg0yt
Copy link
Copy Markdown
Contributor

dg0yt commented May 19, 2021

Seems that the issue I am having with Windows support for libtasn1 is related: #16953 (comment)

I don't think so. Your issue is with windows triplets. This PR is for mingw triplets, and the libtasn1 issues on osx were not related to wrappers.

@wrobelda
Copy link
Copy Markdown
Contributor

wrobelda commented May 19, 2021 •
edited
Loading

I don't think so. Your issue is with windows triplets. This PR is for mingw triplets, and the libtasn1 issues on osx were not related to wrappers.

Not sure why you bring up macOS – #16953 is specifically to fix Windows build, and indeed this PR does seem fix (or alter) the ar-lib call for me, although with another error showing now, which may be related still:

Makefile:687: update target 'libgnu.la' due to: c-ctype.lo strverscmp.lo
/bin/sh ../../libtool  --tag=CC   --mode=link /c/vcpkg/buildtrees/libtasn1/src/4.16.0-e9554bb491.clean/build-aux/compile cl.exe  -nologo -W3 -utf-8 -MP -MDd -Z7 -Ob0 -Od -Xcompiler -RTC1  -no-undefined -LC:/vcpkg/installed/x86-windows/debug/lib -LC:/vcpkg/installed/x86-windows/debug/lib/manual-link -o libgnu.la  c-ctype.lo strverscmp.lo -lkernel32 -luser32 -lgdi32 -lwinspool -lshell32 -lole32 -loleaut32 -lcomdlg32 -ladvapi32 -lgettimeofday -lgetopt
libtool: link: lib.exe cru .libs/gnu.lib .libs/c-ctype.obj .libs/strverscmp.obj 
Microsoft (R) Library Manager Version 14.28.29337.0
Copyright (C) Microsoft Corporation.  All rights reserved.

LINK : fatal error LNK1181: cannot open input file 'cru'

EDIT: @dg0yt scratch everything, I totally messed up my checkouts. This PR has no effect on my PR, sorry for the confusion.

@JackBoosY JackBoosY removed depends:different-pr This PR or Issue depends on a PR which has been filed requires:author-response labels May 20, 2021
@JackBoosY JackBoosY added info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. info:world-rebuild labels May 20, 2021
@dg0yt dg0yt mentioned this pull request May 20, 2021
Closed
past-due
past-due approved these changes May 20, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@past-due past-due left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that this fixes several issues I have encountered with mingw (clang environments). 👍

@JackBoosY JackBoosY requested a review from strega-nil-ms May 25, 2021 09:04
@ras0219-msft ras0219-msft merged commit fbbadfc into microsoft:master May 26, 2021
@ras0219-msft
Copy link
Copy Markdown
Contributor

ras0219-msft commented May 26, 2021

This LGTM, thanks for the PR!

@huangqinjin huangqinjin deleted the automake-wrappers branch May 30, 2021 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@strega-nil-ms strega-nil-ms Awaiting requested review from strega-nil-ms

3 more reviewers

@Neumann-A Neumann-A Neumann-A left review comments

@past-due past-due past-due approved these changes

@JackBoosY JackBoosY JackBoosY approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@JackBoosY JackBoosY

Labels

category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@huangqinjin @dg0yt @JackBoosY @wrobelda @ras0219-msft @Neumann-A @past-due