Skip to content

[vcpkg/scripts/make] add compiler tools to PATH#17085

Merged
vicroms merged 2 commits intomicrosoft:masterfrom
huangqinjin:make-compiler-path
Apr 7, 2021
Merged

[vcpkg/scripts/make] add compiler tools to PATH#17085
vicroms merged 2 commits intomicrosoft:masterfrom
huangqinjin:make-compiler-path

Conversation

@huangqinjin
Copy link
Copy Markdown
Contributor

@huangqinjin huangqinjin commented Apr 4, 2021

No description provided.

@huangqinjin huangqinjin mentioned this pull request Apr 4, 2021
Closed
@JackBoosY JackBoosY self-assigned this Apr 5, 2021
@JackBoosY
Copy link
Copy Markdown
Contributor

JackBoosY commented Apr 5, 2021

cc @Neumann-A

@JackBoosY JackBoosY added the category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly label Apr 5, 2021
@SamuelMarks
Copy link
Copy Markdown
Contributor

SamuelMarks commented Apr 5, 2021

[offtopic]
So is this to compile the GNU make binary? - Or to take non CMake projects and enable them to work with vcpkg? - Or to aid in rewriting autotools incl. make projects into CMake ones?

PS: Looks like they fixed Windows again http://git.savannah.gnu.org/cgit/make.git/commit/?id=1ae90c030d5ffc79f74e3938880445a6b8b2412e
[/offtopic]

@Neumann-A
Copy link
Copy Markdown
Contributor

Neumann-A commented Apr 5, 2021

@SamuelMarks This: Or to take non CMake projects and enable them to work with vcpkg?

vcpkg_configure_make takes the cmake toolchain and setups everything so that configure/make works with the cmake toolchain.

Why is it assumed that the compiler is on the path:
SPACES
autotools are really bad in handling spaces in paths. The normal way vcpkg is setup on windows uses vcvars which puts the compiler on the path. That is why it is assumed here.

Neumann-A
Neumann-A reviewed Apr 5, 2021
View reviewed changes
Neumann-A
Neumann-A reviewed Apr 5, 2021
View reviewed changes
@JackBoosY
Copy link
Copy Markdown
Contributor

JackBoosY commented Apr 6, 2021

Waiting for #17083 merge.

@JackBoosY JackBoosY added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Apr 7, 2021
@vicroms vicroms merged commit 64efdb4 into microsoft:master Apr 7, 2021
@huangqinjin huangqinjin deleted the make-compiler-path branch April 11, 2021 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@Neumann-A Neumann-A Neumann-A left review comments

@JackBoosY JackBoosY JackBoosY approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@JackBoosY JackBoosY

Labels

category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@huangqinjin @JackBoosY @SamuelMarks @Neumann-A @vicroms