Skip to content

[vcpkg baseline][pangolin] Add options to dependencies to avoid finding them automatically#17014

Merged
vicroms merged 4 commits intomicrosoft:masterfrom
JackBoosY:dev/jack/fix_baseline_20210401
Apr 1, 2021
Merged

[vcpkg baseline][pangolin] Add options to dependencies to avoid finding them automatically#17014
vicroms merged 4 commits intomicrosoft:masterfrom
JackBoosY:dev/jack/fix_baseline_20210401

Conversation

@JackBoosY
Copy link
Copy Markdown
Contributor

@JackBoosY JackBoosY commented Apr 1, 2021

Fixes #17005

Since the search for many dependencies in pangolin's cmakelists.txt is silent, it is possible to hide the use of undeclared dependencies, so add cmake options CMAKE_DISABLE_FIND_PACKAGE_PORT to disable them.

Related: #16994.

@JackBoosY JackBoosY added category:port-bug The issue is with a library, which is something the port should already support info:internal labels Apr 1, 2021
@autoantwort
Copy link
Copy Markdown
Contributor

Maybe we should also report this upstream

@JackBoosY
Copy link
Copy Markdown
Contributor Author

@autoantwort No, some upstreams tend to use find_package(.. QUIET) to find dependencies, which is their freedom.

@JackBoosY JackBoosY requested a review from PhoebeHui April 1, 2021 11:36
@JackBoosY JackBoosY linked an issue Apr 1, 2021 that may be closed by this pull request
Copy link
Copy Markdown
Contributor

@PhoebeHui PhoebeHui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PhoebeHui PhoebeHui added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Apr 1, 2021
@vicroms vicroms merged commit 7d40a54 into microsoft:master Apr 1, 2021
@JackBoosY JackBoosY deleted the dev/jack/fix_baseline_20210401 branch April 2, 2021 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-bug The issue is with a library, which is something the port should already support info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[pangolin] build failure on linux

4 participants