Skip to content

[scripts/vcpkgTools.xml] add specs for gsutil#16462

Merged
strega-nil-ms merged 2 commits intomicrosoft:masterfrom
coryan:feat-add-description-for-gsutil
Jun 9, 2021
Merged

[scripts/vcpkgTools.xml] add specs for gsutil#16462
strega-nil-ms merged 2 commits intomicrosoft:masterfrom
coryan:feat-add-description-for-gsutil

Conversation

@coryan
Copy link
Copy Markdown
Contributor

@coryan coryan commented Feb 28, 2021

Add specifications to download gsutil for Linux, Windows, and macOS.

  • What does your PR fix? Fixes #

Fixes #16288, after the corresponding PR in vcpkg-tool (microsoft/vcpkg-tool#19)

  • Which triplets are supported/not supported? Have you updated the CI baseline?

N/A

Yes.

@coryan coryan marked this pull request as ready for review February 28, 2021 19:39
@JackBoosY JackBoosY requested a review from ras0219-msft March 1, 2021 03:05
@JackBoosY JackBoosY added category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed requires:discussion labels Mar 1, 2021
@JackBoosY JackBoosY added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Mar 1, 2021
ras0219-msft
ras0219-msft reviewed Mar 2, 2021
View reviewed changes
@JackBoosY JackBoosY removed the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Mar 2, 2021
@JackBoosY
Copy link
Copy Markdown
Contributor

JackBoosY commented May 25, 2021

Ping @coryan for response, Is work still being done for this PR?

@coryan
Copy link
Copy Markdown
Contributor Author

coryan commented May 25, 2021

Work is still pending, I have been distracted by my main job and life.

PS: I think I need to change the tarball that gets downloaded, there is a larger one that includes gsutil.cmd which seems more friendly for Windows.

@JackBoosY JackBoosY requested a review from ras0219-msft June 7, 2021 07:12
@JackBoosY JackBoosY added info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. and removed requires:author-response labels Jun 7, 2021
@JackBoosY
Copy link
Copy Markdown
Contributor

JackBoosY commented Jun 7, 2021

LGTM on my side.

@strega-nil-ms
Copy link
Copy Markdown
Contributor

strega-nil-ms commented Jun 9, 2021

LGTM, thanks!

@strega-nil-ms strega-nil-ms merged commit a4838ab into microsoft:master Jun 9, 2021
@coryan coryan deleted the feat-add-description-for-gsutil branch March 11, 2022 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ras0219-msft ras0219-msft Awaiting requested review from ras0219-msft

1 more reviewer

@JackBoosY JackBoosY JackBoosY approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@JackBoosY JackBoosY

Labels

category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[vcpkg] Add gsutil to list of downloadable tools in

4 participants

@coryan @JackBoosY @strega-nil-ms @ras0219-msft