Skip to content

[CGAL] switch dep to gmp instead of mpir#15860

Merged
dan-shaw merged 2 commits intomicrosoft:masterfrom
Neumann-A:cgal_switch_to_gmp
Jan 29, 2021
Merged

[CGAL] switch dep to gmp instead of mpir#15860
dan-shaw merged 2 commits intomicrosoft:masterfrom
Neumann-A:cgal_switch_to_gmp

Conversation

@Neumann-A
Copy link
Copy Markdown
Contributor

@Neumann-A Neumann-A commented Jan 25, 2021 •
edited
Loading

enable builds in CI again

closes #15881

@Neumann-A Neumann-A mentioned this pull request Jan 25, 2021
Merged
@cenit
Copy link
Copy Markdown
Contributor

cenit commented Jan 25, 2021

just a question: why not using gmp on linux/osx and mpir on windows?
They should be compatible and also give you the best result on respective platform. Or is it uniformity valued more?

@Neumann-A
Copy link
Copy Markdown
Contributor Author

Neumann-A commented Jan 25, 2021

@cenit gmp is more actively maintained (last release end of 2020) while the mpir MSVC branch is not (last release end of 2017). As such using gmp everywhere seems to be the better alternative.

@Neumann-A
Copy link
Copy Markdown
Contributor Author

Neumann-A commented Jan 25, 2021 •
edited
Loading

The colmap regression in x64-windows-static seems to be due to optional dependencies (e.g. openjpeg) and also wrong linkage of FreeImage (release vs debug) and should also fail in the baseline if those dependencies are found.

@cenit
Copy link
Copy Markdown
Contributor

cenit commented Jan 25, 2021 •
edited
Loading

This PR is very urgent for me to unblock a series of nightly pipelines which got broken otherwise from #13081 merged. I hope it can be merged soon

@JackBoosY JackBoosY self-assigned this Jan 26, 2021
@JackBoosY JackBoosY added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Jan 26, 2021
@JackBoosY
Copy link
Copy Markdown
Contributor

JackBoosY commented Jan 26, 2021

@Neumann-A I will check later.

@JackBoosY
Copy link
Copy Markdown
Contributor

JackBoosY commented Jan 26, 2021 

-- Found FreeImage
--   Includes : D:/installed/x64-windows-static/include
--   Libraries : D:/installed/x64-windows-static/lib/FreeImage.lib

Only provides the release library.

@Neumann-A Neumann-A mentioned this pull request Jan 26, 2021
Closed
@JackBoosY JackBoosY mentioned this pull request Jan 26, 2021
Merged
@JackBoosY JackBoosY added the depends:different-pr This PR or Issue depends on a PR which has been filed label Jan 26, 2021
@JackBoosY
Copy link
Copy Markdown
Contributor

JackBoosY commented Jan 26, 2021

Will be fixed in #15886.

@JackBoosY JackBoosY removed the depends:different-pr This PR or Issue depends on a PR which has been filed label Jan 28, 2021
@JackBoosY
Copy link
Copy Markdown
Contributor

JackBoosY commented Jan 28, 2021

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Jan 28, 2021

Azure Pipelines successfully started running 1 pipeline(s).

@JackBoosY JackBoosY added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Jan 28, 2021
@JackBoosY
Copy link
Copy Markdown
Contributor

JackBoosY commented Jan 28, 2021

LGTM.

@dan-shaw dan-shaw merged commit 7f400c4 into microsoft:master Jan 29, 2021
@Neumann-A Neumann-A deleted the cgal_switch_to_gmp branch January 29, 2021 07:38
@acgetchell acgetchell mentioned this pull request Jan 30, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@JackBoosY JackBoosY JackBoosY approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@JackBoosY JackBoosY

Labels

category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[cgal] build failure with latest version

4 participants

@Neumann-A @cenit @JackBoosY @dan-shaw