[gtest] Add a patch to fix build error in GCC 11#15661
Merged
dan-shaw merged 3 commits intomicrosoft:masterfrom Jan 15, 2021
Merged
[gtest] Add a patch to fix build error in GCC 11#15661dan-shaw merged 3 commits intomicrosoft:masterfrom
dan-shaw merged 3 commits intomicrosoft:masterfrom
Conversation
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
NancyLi1013
reviewed
Jan 15, 2021
Contributor
NancyLi1013
left a comment
There was a problem hiding this comment.
Could you please also bump Port-Version as 3 in CONTROL file?
92700d1 to
9121ce7
Compare
NancyLi1013
approved these changes
Jan 15, 2021
Contributor
|
LGTM now, thanks for your PR @PragmaTwice. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the pull request
What does your PR fix?
Fixes [gtest] build failure while using GCC 11 (trunk) #15617.
To summarize, gtest 1.10.0 failed to compile in GCC 11, and no other versions will be released due to their policy (live in head, no release tags), so a patch is the only way to solve it.
Which triplets are supported/not supported? Have you updated the CI baseline?
No change.
Does your PR follow the maintainer guide?
Yes.