[vcpkg_apply_patches] don't change line endings on patching.#15578
Merged
dan-shaw merged 1 commit intomicrosoft:masterfrom Jan 14, 2021
Merged
[vcpkg_apply_patches] don't change line endings on patching.#15578dan-shaw merged 1 commit intomicrosoft:masterfrom
dan-shaw merged 1 commit intomicrosoft:masterfrom
Conversation
Contributor
|
Will this affect some problems? |
Contributor
Author
|
I don't know of any issues within vcpkg yet. I just observed a failure in #9966 due to changed line endings due to autoconf expecting unix line endings. In general patching should not ws change the downloaded sources. |
JackBoosY
approved these changes
Jan 12, 2021
Contributor
|
I hope my colleague will review it further. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
otherwise autoconf could run into problems when configure.ac is patched.