Skip to content

[python2] Add feature tools#15457

Closed
JackBoosY wants to merge 2 commits intomicrosoft:masterfrom
JackBoosY:dev/jack/python2_add_tools
Closed

[python2] Add feature tools#15457
JackBoosY wants to merge 2 commits intomicrosoft:masterfrom
JackBoosY:dev/jack/python2_add_tools

Conversation

@JackBoosY
Copy link
Copy Markdown
Contributor

@JackBoosY JackBoosY commented Jan 5, 2021

Add feature tools to build and install python executables.
To fix the issue:

Traceback (most recent call last):
  File "D:\buildtrees\cppcms\src\20a4ad93d4-26c9d29282.clean\bin\cppcms_tmpl_cc", line 14, in <module>
    import StringIO
ModuleNotFoundError: No module named 'StringIO'

@JackBoosY JackBoosY added category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:internal labels Jan 5, 2021
@JackBoosY
Copy link
Copy Markdown
Contributor Author

JackBoosY commented Jan 5, 2021

We should consider to remove PYTHON2 and PYTHON3 in vcpkg_find_acquire_program.

@JackBoosY
Copy link
Copy Markdown
Contributor Author

JackBoosY commented Jan 5, 2021

We should also refer to manual-link to create a separate tool folder to avoid adding their path to CMAKE_PREFIX_PATH.

@Hoikas
Copy link
Copy Markdown
Contributor

Hoikas commented Jan 5, 2021

The python2 port doesn't support macOS or linux AFAIK. Further, the Python executables built by static triplets have undesirable edge cases on Windows. It might be better to wait until after #15424 for this.

@Hoikas Hoikas mentioned this pull request Jan 5, 2021
Closed
@Hoikas
Copy link
Copy Markdown
Contributor

Hoikas commented Jan 5, 2021

I've pushed an update to the python3 vcpkg-cmake-wrapper in #15221 that should fix this problem.

@JackBoosY
Copy link
Copy Markdown
Contributor Author

JackBoosY commented Jan 6, 2021

Since #15221 has partially solved the python issue, I will close this PR now.

@JackBoosY JackBoosY closed this Jan 6, 2021
@JackBoosY JackBoosY deleted the dev/jack/python2_add_tools branch May 26, 2022 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@PhoebeHui PhoebeHui

Labels

category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JackBoosY @Hoikas @PhoebeHui