Skip to content

[mp3lame] Fix lib suffix on Unix#15058

Merged
BillyONeal merged 1 commit intomicrosoft:masterfrom
NancyLi1013:dev/NancyLi/fix-mp3lame
Dec 12, 2020
Merged

[mp3lame] Fix lib suffix on Unix#15058
BillyONeal merged 1 commit intomicrosoft:masterfrom
NancyLi1013:dev/NancyLi/fix-mp3lame

Conversation

@NancyLi1013
Copy link
Copy Markdown
Contributor

Describe the pull request

Currently, _mp3lame_rel_lib in ../share/mp3lame/mp3lame-config.cmake is like this:

set(_mp3lame_rel_lib "${_mp3lame_root}/lib/libmp3lame..a")
set(_mp3lame_dbg_lib "${_mp3lame_root}/debug/lib/libmp3lame..a")

VCPKG_TARGET_STATIC_LIBRARY_SUFFIX has included ".", it's unnecessary to add it again.

So remove additional "." , only using ${VCPKG_TARGET_STATIC_LIBRARY_SUFFIX} to fix this issue.

Note: No feature needs to test.

@NancyLi1013 NancyLi1013 added category:port-bug The issue is with a library, which is something the port should already support info:internal labels Dec 11, 2020
@PhoebeHui PhoebeHui added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Dec 11, 2020
@BillyONeal BillyONeal merged commit 929c7d9 into microsoft:master Dec 12, 2020
@BillyONeal
Copy link
Copy Markdown
Member

Excellent!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-bug The issue is with a library, which is something the port should already support info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[libx264] build failure on linux

3 participants