Skip to content

[opencascade] Fix OpenCASCADE_INSTALL_PREFIX path in config#15056

Merged
BillyONeal merged 1 commit intomicrosoft:masterfrom
NancyLi1013:dev/NancyLi/fix-opencascade
Dec 12, 2020
Merged

[opencascade] Fix OpenCASCADE_INSTALL_PREFIX path in config#15056
BillyONeal merged 1 commit intomicrosoft:masterfrom
NancyLi1013:dev/NancyLi/fix-opencascade

Conversation

@NancyLi1013
Copy link
Copy Markdown
Contributor

Describe the pull request

Currently, OpenCASCADE_INSTALL_PREFIX path is like this:

OpenCASCADE_INSTALL_PREFIX=D:/vcpkg/installed/x64-windows/share

This causes OpenCASCADE_INCLUDE_DIR and OpenCASCADE_LIBRARY_DIR are wrong.

OpenCASCADE_INCLUDE_DIR =D:/vcpkg/installed/x64-windows/share/include/opencascade

OpenCASCADE_LIBRARY_DIR=D:/vcpkg/installed/x64-windows/share/lib

So need to fix OpenCASCADE_INSTALL_PREFIX path.

Note: All features are not needed to test.

@NancyLi1013 NancyLi1013 added category:port-bug The issue is with a library, which is something the port should already support info:internal labels Dec 11, 2020
@JackBoosY JackBoosY added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Dec 11, 2020
@BillyONeal BillyONeal merged commit 3b935db into microsoft:master Dec 12, 2020
@BillyONeal
Copy link
Copy Markdown
Member

Thank you!

@sudo-liljoa
Copy link
Copy Markdown
Contributor

This issue is back again after upgrade to OCC 7.5.0,
#15997

@NancyLi1013
Copy link
Copy Markdown
Contributor Author

Thanks for reporting this issue @socuwn.

I found that the patch was removed in PR #15997. I think we can add it back to PR #16513.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-bug The issue is with a library, which is something the port should already support info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[opencascade] OpenCASCADE_INCLUDE_DIR at wrong location

4 participants