Skip to content

[osg] build failure#15044

Merged
BillyONeal merged 5 commits intomicrosoft:masterfrom
JonLiu1993:dev/Jon/osg
Dec 15, 2020
Merged

[osg] build failure#15044
BillyONeal merged 5 commits intomicrosoft:masterfrom
JonLiu1993:dev/Jon/osg

Conversation

@JonLiu1993
Copy link
Copy Markdown
Contributor

@JonLiu1993 JonLiu1993 commented Dec 10, 2020

Describe the pull request

  • What does your PR fix? Fixes [osg] build failure #14994
    Iconv does not provide the IconvConfig.cmake file and cannot use the config mode for searching, so need to delete the CONFIG parameter in find_package (Iconv CONFIG REQUIRED)

All features have tested successfully in the following triplets:

  • x86-windows
  • x64-windows
  • x64-windows-static

@JonLiu1993 JonLiu1993 added category:port-bug The issue is with a library, which is something the port should already support info:internal labels Dec 10, 2020
@JonLiu1993 JonLiu1993 marked this pull request as ready for review December 11, 2020 08:32
@NancyLi1013 NancyLi1013 added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Dec 14, 2020
@BillyONeal
Copy link
Copy Markdown
Member

BillyONeal commented Dec 15, 2020

Isn't Iconv::Iconv provided by the config file? I think the missing config file is the source of the problem that must be addressed, not one of the downstream consumers here.

@JonLiu1993
Copy link
Copy Markdown
Contributor Author

JonLiu1993 commented Dec 15, 2020

Isn't Iconv::Iconv provided by the config file? I think the missing config file is the source of the problem that must be addressed, not one of the downstream consumers here.
@BillyONeal , the cmake file provided by us before osg was written by nmake, but the cmake provided by myself was deleted in the subsequent version submitted. Now iconv does not have a configuration file that can be used

@BillyONeal
Copy link
Copy Markdown
Member

BillyONeal commented Dec 15, 2020

@JonLiu1993 If there's no config file where does Iconv::Iconv come from?

@BillyONeal
Copy link
Copy Markdown
Member

BillyONeal commented Dec 15, 2020

Robert points out that Iconv::Iconv is a cmake builtin module. Sorry for the confusion and thanks!

@BillyONeal BillyONeal merged commit c744bdf into microsoft:master Dec 15, 2020
@JonLiu1993 JonLiu1993 deleted the dev/Jon/osg branch December 23, 2020 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@NancyLi1013 NancyLi1013 NancyLi1013 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@NancyLi1013 NancyLi1013

Labels

category:port-bug The issue is with a library, which is something the port should already support info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[osg] build failure

3 participants

@JonLiu1993 @BillyONeal @NancyLi1013