Skip to content

[sentry-native] Fix sentry-config-cmake.in#15042

Merged
BillyONeal merged 1 commit intomicrosoft:masterfrom
JackBoosY:dev/jack/15023
Dec 12, 2020
Merged

[sentry-native] Fix sentry-config-cmake.in#15042
BillyONeal merged 1 commit intomicrosoft:masterfrom
JackBoosY:dev/jack/15023

Conversation

@JackBoosY
Copy link
Copy Markdown
Contributor

@JackBoosY JackBoosY commented Dec 10, 2020

  • In *-config.cmake, we should use find_dependency instead of find_package.
  • Fix curl target name.

Fixes #15023.

@JackBoosY JackBoosY added category:port-bug The issue is with a library, which is something the port should already support info:internal labels Dec 10, 2020
@NancyLi1013 NancyLi1013 added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Dec 10, 2020
@JackBoosY
Copy link
Copy Markdown
Contributor Author

JackBoosY commented Dec 10, 2020

@korrix Can you please test this PR?

Thanks.

@BillyONeal BillyONeal merged commit a9df4e2 into microsoft:master Dec 12, 2020
@BillyONeal
Copy link
Copy Markdown
Member

BillyONeal commented Dec 12, 2020

image

@JackBoosY JackBoosY deleted the dev/jack/15023 branch December 14, 2020 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@NancyLi1013 NancyLi1013 NancyLi1013 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@NancyLi1013 NancyLi1013

Labels

category:port-bug The issue is with a library, which is something the port should already support info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[sentry-native] build failure / problem with curl dependency

3 participants

@JackBoosY @BillyONeal @NancyLi1013