Skip to content

[glib] Enable static build#15034

Closed
JackBoosY wants to merge 20 commits intomicrosoft:masterfrom
JackBoosY:dev/jack/3409
Closed

[glib] Enable static build#15034
JackBoosY wants to merge 20 commits intomicrosoft:masterfrom
JackBoosY:dev/jack/3409

Conversation

@JackBoosY
Copy link
Copy Markdown
Contributor

@JackBoosY JackBoosY commented Dec 10, 2020 •
edited
Loading

  • Enable static build on Windows.
  • Disable export function dllmain in glib and gobject.
  • Add missing definition GLIB_STATIC_COMPILATION and GOBJECT_STATIC_COMPILAT when building static.
  • Fix the static build of ports partially that depend on glib.

Fixes #3409.

@JackBoosY JackBoosY added category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:internal labels Dec 10, 2020
@JackBoosY JackBoosY requested a review from PhoebeHui December 11, 2020 05:43
@JackBoosY JackBoosY added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Dec 15, 2020
@BillyONeal
Copy link
Copy Markdown
Member

BillyONeal commented Dec 16, 2020

/azp run

@BillyONeal BillyONeal closed this Dec 16, 2020
@BillyONeal BillyONeal reopened this Dec 16, 2020
@BillyONeal
Copy link
Copy Markdown
Member

BillyONeal commented Dec 16, 2020

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Dec 16, 2020

Azure Pipelines successfully started running 1 pipeline(s).

@JackBoosY
Copy link
Copy Markdown
Contributor Author

JackBoosY commented Dec 16, 2020

For qt5-base:

vcpkg/ports/qt5-base/portfile.cmake

Lines 184 to 189 in 49972a6

find_library(GLIB_RELEASE NAMES glib-${GLIB_LIB_VERSION} PATHS "${CURRENT_INSTALLED_DIR}/lib" NO_DEFAULT_PATH)
find_library(GLIB_DEBUG NAMES glib-${GLIB_LIB_VERSION} PATHS "${CURRENT_INSTALLED_DIR}/debug/lib" NO_DEFAULT_PATH)
if(GLIB_RELEASE MATCHES "-NOTFOUND" OR GLIB_DEBUG MATCHES "-NOTFOUND")
set(GLIB_RELEASE "")
set(GLIB_DEBUG "")
endif()

Here we must add glib dependencies during static build, or directly use find_package to find zlib and use its targets.

@BillyONeal
Copy link
Copy Markdown
Member

BillyONeal commented Dec 18, 2020

Sorry about the qt issue @JackBoosY, I'm hoping to look at it soon

@JackBoosY JackBoosY removed the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Dec 28, 2020
@Neumann-A Neumann-A mentioned this pull request Jan 19, 2021
Merged
3 tasks
@JackBoosY JackBoosY added the depends:different-pr This PR or Issue depends on a PR which has been filed label Jan 20, 2021
@PhoebeHui PhoebeHui marked this pull request as draft January 22, 2021 02:23
@JackBoosY
Copy link
Copy Markdown
Contributor Author

JackBoosY commented Feb 7, 2021

Close this PR temporary.

@JackBoosY JackBoosY closed this Feb 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@PhoebeHui PhoebeHui PhoebeHui approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@PhoebeHui PhoebeHui

Labels

category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist depends:different-pr This PR or Issue depends on a PR which has been filed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

glib:x64-windows-static failing

3 participants

@JackBoosY @BillyONeal @PhoebeHui