Skip to content

[dav1d] Add dav1d AV1 decoder port#15009

Merged
dan-shaw merged 7 commits intomicrosoft:masterfrom
RichLogan:dav1d
Jan 25, 2021
Merged

[dav1d] Add dav1d AV1 decoder port#15009
dan-shaw merged 7 commits intomicrosoft:masterfrom
RichLogan:dav1d

Conversation

@RichLogan
Copy link
Copy Markdown
Contributor

@RichLogan RichLogan commented Dec 8, 2020

Adds dav1d AV1 decoder port

  • Which triplets are supported/not supported? Have you updated the CI baseline?

Struggling with MSVC underscore prefixes on x86-windows. Disabled support in manifest for now.

@ghost
Copy link
Copy Markdown

ghost commented Dec 8, 2020 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

@RichLogan
Copy link
Copy Markdown
Contributor Author

RichLogan commented Dec 8, 2020

I think that these are failing on linux due a bug in upstream meson. I will submit a PR to rev vcpkg's meson to try and resolve this.

@NancyLi1013 NancyLi1013 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Dec 9, 2020
NancyLi1013
NancyLi1013 suggested changes Dec 9, 2020
View reviewed changes
@NancyLi1013
Copy link
Copy Markdown
Contributor

NancyLi1013 commented Dec 9, 2020

@RichLogan

Could you please sign CLA first?

@RichLogan RichLogan mentioned this pull request Dec 18, 2020
Merged
@RichLogan
Copy link
Copy Markdown
Contributor Author

RichLogan commented Dec 18, 2020

Depends: #15200

@NancyLi1013 NancyLi1013 added the depends:different-pr This PR or Issue depends on a PR which has been filed label Dec 21, 2020
@JackBoosY JackBoosY removed the depends:different-pr This PR or Issue depends on a PR which has been filed label Jan 14, 2021
@JackBoosY
Copy link
Copy Markdown
Contributor

JackBoosY commented Jan 14, 2021

Can you continue this PR now?

@RichLogan RichLogan marked this pull request as draft January 15, 2021 18:30
@RichLogan RichLogan marked this pull request as ready for review January 17, 2021 13:02
@RichLogan
Copy link
Copy Markdown
Contributor Author

RichLogan commented Jan 18, 2021

I think this is ready but I need some help with why x86-windows is failing on the "Validate Version Files" step.

@NancyLi1013
Copy link
Copy Markdown
Contributor

NancyLi1013 commented Jan 18, 2021

Could you please merge master and run command vcpkg x-add-version dav1d ?

Found the following errors:
Error: While validating port dav1d.
       Missing expected versions file at: C:\a\1\s\port_versions\d-\dav1d.json
       Run:

           vcpkg x-add-version dav1d

       to create the versions file.

To attempt to resolve all errors at once, run:

    vcpkg x-add-version --all

@RichLogan
Copy link
Copy Markdown
Contributor Author

RichLogan commented Jan 18, 2021

@NancyLi1013 All done, thanks!

NancyLi1013
NancyLi1013 suggested changes Jan 19, 2021
View reviewed changes
@RichLogan RichLogan requested a review from NancyLi1013 January 19, 2021 09:37
@RichLogan
Copy link
Copy Markdown
Contributor Author

RichLogan commented Jan 22, 2021

@NancyLi1013 Can this be merged now?

@NancyLi1013 NancyLi1013 added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Jan 25, 2021
@NancyLi1013
Copy link
Copy Markdown
Contributor

NancyLi1013 commented Jan 25, 2021

LGTM now, thanks for your PR @RichLogan.

@dan-shaw dan-shaw merged commit fc0d6b2 into microsoft:master Jan 25, 2021
@RichLogan RichLogan deleted the dav1d branch January 25, 2021 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@NancyLi1013 NancyLi1013 NancyLi1013 approved these changes

@JackBoosY JackBoosY JackBoosY approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@NancyLi1013 NancyLi1013

Labels

category:new-port The issue is requesting a new library to be added; consider making a PR! info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@RichLogan @NancyLi1013 @JackBoosY @dan-shaw