[sdl2] Don't propagate shared link options#14992
Merged
BillyONeal merged 1 commit intomicrosoft:masterfrom Dec 11, 2020
JesseFarebro:master
Merged
[sdl2] Don't propagate shared link options#14992BillyONeal merged 1 commit intomicrosoft:masterfrom JesseFarebro:master
BillyONeal merged 1 commit intomicrosoft:masterfrom
JesseFarebro:master
Conversation
|
|
NancyLi1013
suggested changes
Dec 8, 2020
Contributor
NancyLi1013
left a comment
There was a problem hiding this comment.
Could you please also bump port-version in vcpkg.json file?
Contributor
Author
|
Updated the PR according to your comments. Thanks for the quick feedback! |
NancyLi1013
approved these changes
Dec 9, 2020
Contributor
Author
|
@NancyLi1013 should this be relabelled to |
Contributor
|
Have you tested the feature |
Contributor
Author
|
I just tested with the |
Contributor
|
Thanks for your feedback @JesseFarebro. LGTM now. |
Member
|
Thanks for this backport! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the pull request
This is a patch so that SDL2 doesn't propagate link flags for shared builds. This can be problematic in certain cases, for example, SDL2 specifies
-Wl,--no-undefinedas a linker flag and this will get propagated to all dependent projects.There are upstream issues
It's worth noting that this problem IS fixed in SDL 2.0.13 which hasn't been released yet. See spurious/SDL-mirror@07d40b7 for the specific commit / more info. When 2.0.13 is released we can get rid of this patch.
What does your PR fix? Fixes [sdl2] don't specify -Wl,--no-undefined on INTERFACE_LINK_LIBRARIES #14743
Which triplets are supported/not supported? Have you updated the CI baseline?
This fixes dynamic triplets, so any community-supported triplets like
x64-linux-dynamic.Does your PR follow the maintainer guide?
Yes.