[vcpkg] x_vcpkg_install_local_dependencies fixes#14977
Merged
ras0219-msft merged 2 commits intomicrosoft:masterfrom Dec 8, 2020
Merged
[vcpkg] x_vcpkg_install_local_dependencies fixes#14977ras0219-msft merged 2 commits intomicrosoft:masterfrom
ras0219-msft merged 2 commits intomicrosoft:masterfrom
Conversation
BillyONeal
approved these changes
Dec 7, 2020
Contributor
|
Thanks for the fixes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch addresses two issues.
First is a bug in the argument parsing introduced when switching to the PARSE_ARGV style parsing. As this was simply missing an argument where to start the parsing from. As this is in an experimental feature it probably wasn't found earlier.
Second issue is that install command also works on
INTERFACEtargets, but that there is no way to get a$<TARGET_FILE_NAME:target>on that as these targets simply don't have it. So skipping the install code when target is of typeINTEFACE_LIBRARY