Skip to content

[flashlight-cuda] Add stb as dependency, bump port commit#14912

Merged
BillyONeal merged 4 commits intomicrosoft:masterfrom
jacobkahn:flashlight_fix
Dec 5, 2020
Merged

[flashlight-cuda] Add stb as dependency, bump port commit#14912
BillyONeal merged 4 commits intomicrosoft:masterfrom
jacobkahn:flashlight_fix

Conversation

@jacobkahn
Copy link
Copy Markdown
Contributor

stb should be a dependency but isn't. If the flashlight build doesn't find stb, it downloads it from source, which is bad because there might be multiple headers for the same project if a downstream project uses the stb vcpkg port. This also caused a problem because flashlight tried to install the downloaded stb headers which resulted in some empty directories/could break the port.

Also updates the port commit to have some fixes to the nvcc -std/C++ compiler version.

  • Which triplets are supported/not supported? Have you updated the CI baseline?

Same triplets as before. No changes.

Yes

Copy link
Copy Markdown
Contributor

@PhoebeHui PhoebeHui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@PhoebeHui PhoebeHui added category:port-update The issue is with a library, which is requesting update new revision requires:author-response labels Dec 3, 2020
@PhoebeHui PhoebeHui added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Dec 4, 2020
@BillyONeal BillyONeal merged commit 8573930 into microsoft:master Dec 5, 2020
@BillyONeal
Copy link
Copy Markdown
Member

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-update The issue is with a library, which is requesting update new revision info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants