[flashlight-cuda] Add stb as dependency, bump port commit#14912
Merged
BillyONeal merged 4 commits intomicrosoft:masterfrom Dec 5, 2020
Merged
[flashlight-cuda] Add stb as dependency, bump port commit#14912BillyONeal merged 4 commits intomicrosoft:masterfrom
BillyONeal merged 4 commits intomicrosoft:masterfrom
Conversation
PhoebeHui
approved these changes
Dec 3, 2020
Member
|
Thanks for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
stbshould be a dependency but isn't. If the flashlight build doesn't find stb, it downloads it from source, which is bad because there might be multiple headers for the same project if a downstream project uses the stb vcpkg port. This also caused a problem because flashlight tried to install the downloaded stb headers which resulted in some empty directories/could break the port.Also updates the port commit to have some fixes to the nvcc
-std/C++ compiler version.Same triplets as before. No changes.
Yes