Skip to content

[termcolor]; Add termcolor#14897

Merged
BillyONeal merged 3 commits intomicrosoft:masterfrom
theidexisted:add_termcolor_2
Dec 5, 2020
Merged

[termcolor]; Add termcolor#14897
BillyONeal merged 3 commits intomicrosoft:masterfrom
theidexisted:add_termcolor_2

Conversation

@theidexisted
Copy link
Copy Markdown
Contributor

@theidexisted theidexisted commented Dec 2, 2020

Describe the pull request

  • What does your PR fix? Fixes #

Add new library termcolor

  • Which triplets are supported/not supported? Have you updated the CI baseline?

support Win and Linux

@JackBoosY JackBoosY added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Dec 2, 2020
@theidexisted
Copy link
Copy Markdown
Contributor Author

theidexisted commented Dec 2, 2020

CI failed but not caused by my PR:



          File path: [ D:/downloads/temp/vtk-vtk-m-f2aa6ad5be1a97e3fb41ef4680ee2c76c3434ac0.tar.gz ]
      Expected hash: [ 2f2a273f74d9a583df9e25a4792440d8d89652fa14b3153f2ea5afbd329b50970e7b9bd68e0ccd036baf5c1f3ad7a8302d95c01dbb30d9a46c045987eebf5370 ]
        Actual hash: [ 35e8a2c0ad6cd3c1f02a71a50d781c89f93909ad27030b406fd69f4fea5c1862c48a6e541fd07562947322c3a69bdfdb54206ae51bb86ef7a710f9e9898e9638 ]

  The file may have been corrupted in transit.  This can be caused by
  proxies.  If you use a proxy, please set the HTTPS_PROXY and HTTP_PROXY
  environment variables to
  "https://user:***@your-proxy-ip-address:port/".

  

Call Stack (most recent call first):
  scripts/cmake/vcpkg_download_distfile.cmake:191 (test_hash)
  scripts/cmake/vcpkg_from_gitlab.cmake:123 (vcpkg_download_distfile)
  ports/vtk-m/portfile.cmake:40 (vcpkg_from_gitlab)
  scripts/ports.cmake:136 (include)


Error: Building package vtk-m:x64-windows failed with: BUILD_FAILED
Elapsed time for package vtk-m:x64-windows: 1.213 s
Starting package 100/104: vtk:x64-windows
Building package vtk[atlmfc,core,paraview,qt,vtkm]:x64-windows...
Error: Building package vtk:x64-windows failed with: CASCADED_DUE_TO_MISSING_DEPENDENCIES
Elapsed time for package vtk:x64-windows: 32 us

@NancyLi1013 Could you please take a look?

@NancyLi1013
Copy link
Copy Markdown
Contributor

NancyLi1013 commented Dec 2, 2020

This is not related with your PR. We have submitted a PR #14884 to fix this.

NancyLi1013
NancyLi1013 suggested changes Dec 2, 2020
View reviewed changes
@theidexisted @NancyLi1013
Update ports/termcolor/vcpkg.json
46318e4 
Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>
NancyLi1013
NancyLi1013 reviewed Dec 2, 2020
View reviewed changes
@NancyLi1013
Copy link
Copy Markdown
Contributor

NancyLi1013 commented Dec 3, 2020

The failures caused by vtk-m are not related with PR. I will rerun this PR once the regressions are solved.

@NancyLi1013
Copy link
Copy Markdown
Contributor

NancyLi1013 commented Dec 4, 2020

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Dec 4, 2020

Azure Pipelines successfully started running 1 pipeline(s).

@NancyLi1013 NancyLi1013 added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Dec 4, 2020
@NancyLi1013
Copy link
Copy Markdown
Contributor

NancyLi1013 commented Dec 4, 2020

LGTM now, thanks for your PR @Prehistoric-penguin.

@BillyONeal BillyONeal merged commit 7dd573a into microsoft:master Dec 5, 2020
@BillyONeal
Copy link
Copy Markdown
Member

BillyONeal commented Dec 5, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@NancyLi1013 NancyLi1013 NancyLi1013 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@NancyLi1013 NancyLi1013

Labels

category:new-port The issue is requesting a new library to be added; consider making a PR! info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@theidexisted @NancyLi1013 @BillyONeal @JackBoosY