Skip to content

[osg] Update dependency#14790

Merged
strega-nil merged 1 commit intomicrosoft:masterfrom
NancyLi1013:dev/NancyLi/fix-osg
Dec 2, 2020
Merged

[osg] Update dependency#14790
strega-nil merged 1 commit intomicrosoft:masterfrom
NancyLi1013:dev/NancyLi/fix-osg

Conversation

@NancyLi1013
Copy link
Copy Markdown
Contributor

@NancyLi1013 NancyLi1013 commented Nov 26, 2020

Describe the pull request

Remove boost from base dependency lists.

Add boost as the dependency lists of feature plugins

Update the dependencies of feature plugins(Change nvtt as nvtt (!x86)).

Note:

Feature plugins has passed with the following triplets:

  • x86-windows

@NancyLi1013 NancyLi1013 added category:port-bug The issue is with a library, which is something the port should already support info:internal labels Nov 26, 2020
@NancyLi1013 NancyLi1013 marked this pull request as ready for review November 27, 2020 07:41
@JackBoosY JackBoosY added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Nov 27, 2020
@remoe
Copy link
Copy Markdown

remoe commented Nov 27, 2020 •
edited
Loading

This is a lot better ;) But it still use boost for all plugins, right? This is not needed. Only "RestHttpDevice" "COLLADA" and ASIO need it?

https://github.com/openscenegraph/OpenSceneGraph/search?q=find_package+boost
https://github.com/openscenegraph/OpenSceneGraph/blob/OpenSceneGraph-3.6/CMakeModules/FindAsio.cmake
https://github.com/openscenegraph/OpenSceneGraph/blob/OpenSceneGraph-3.6/CMakeModules/FindCOLLADA.cmake
https://github.com/openscenegraph/OpenSceneGraph/blob/OpenSceneGraph-3.6/CMakeModules/FindLIBLAS.cmake

@remoe remoe mentioned this pull request Nov 27, 2020
Closed
@JackBoosY JackBoosY added requires:author-response and removed info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. labels Nov 30, 2020
@NancyLi1013
Copy link
Copy Markdown
Contributor Author

NancyLi1013 commented Dec 2, 2020

@remoe

Thanks for your attention. You're right that boost is not required for all plugins. But since plugin has been added as a feature for osg and RestHttpDevice is one part of osgPlugins. We cannot spilt this part separately. If removing boost from the dependency lists of osg[plguins], RestHttpDevice cannot be built anymore.

In a word, I think it would be better to keep boost as its dependency.

@JackBoosY JackBoosY added info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. and removed requires:author-response labels Dec 2, 2020
@remoe
Copy link
Copy Markdown

remoe commented Dec 2, 2020

@NancyLi1013 ok, never used this boost based plugins :)
Is it possible to split it to more features? Most users doesn't need this plugins?

@strega-nil
Copy link
Copy Markdown
Contributor

strega-nil commented Dec 2, 2020

It's likely possible to split plugins up into multiple features; we should consider doing it, but that shouldn't stop this from being merged.

Thanks @NancyLi1013 !

@strega-nil strega-nil merged commit a2135fd into microsoft:master Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@JackBoosY JackBoosY JackBoosY approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@JackBoosY JackBoosY

Labels

category:port-bug The issue is with a library, which is something the port should already support info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[osg] remove of boost

4 participants

@NancyLi1013 @remoe @strega-nil @JackBoosY