Skip to content

[openvdb] Fix dependency issue and usage issue#14651

Merged
strega-nil merged 1 commit intomicrosoft:masterfrom
PhoebeHui:dev/Phoebe/openvdb
Nov 20, 2020
Merged

[openvdb] Fix dependency issue and usage issue#14651
strega-nil merged 1 commit intomicrosoft:masterfrom
PhoebeHui:dev/Phoebe/openvdb

Conversation

@PhoebeHui
Copy link
Copy Markdown
Contributor

Fixes #12271

Openvdb provide built in FindOpenVDB.cmake file, add vcpkg-cmake-wrapper.cmake to handle the usage issue in vcpkg
Fix IlmBase, Blosc OpenEXR to use the targets that intalled by vcpkg

All features test pass with x64-windows

Test:
find_package(OpenVDB CONFIG REQUIRED)
target_link_libraries(openvdbtest PRIVATE OpenVDB::openvdb)

@PhoebeHui PhoebeHui added category:port-bug The issue is with a library, which is something the port should already support info:internal labels Nov 19, 2020
@PhoebeHui PhoebeHui marked this pull request as ready for review November 20, 2020 01:35
@JackBoosY JackBoosY added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Nov 20, 2020
@strega-nil strega-nil merged commit a6966c2 into microsoft:master Nov 20, 2020
@strega-nil
Copy link
Copy Markdown
Contributor

Cool, thanks @PhoebeHui :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-bug The issue is with a library, which is something the port should already support info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

openvdb: Could not find a package configuration file

3 participants