[directxtex] Use CMake build system, add OpenEXR support and dx12 feature#13969
Merged
dan-shaw merged 9 commits intomicrosoft:masterfrom Oct 13, 2020
RT2Code:directxtex
Merged
[directxtex] Use CMake build system, add OpenEXR support and dx12 feature#13969dan-shaw merged 9 commits intomicrosoft:masterfrom RT2Code:directxtex
dan-shaw merged 9 commits intomicrosoft:masterfrom
RT2Code:directxtex
Conversation
Use the provided CMake file instead of the VS solutions to build the library, as recommended in the vcpkg maintainer guide. Also add the openexr feature to enable OpenEXR in the library and its tools. https://github.com/Microsoft/DirectXTex/wiki/Adding-OpenEXR
Contributor
Author
|
Regressions indeed, otherwise it would have been too easy. :) I'll try to fix that as soon as possible. Edit: Fixed, I simply forgot DirectXTex tools couldn't be built on UWP or ARM platforms. |
Hoikas
reviewed
Oct 10, 2020
DirectXTex can be build without DirectX12 to support Windows 7 Service Pack 1 or later platforms, so I added this as a feature.
Hoikas
reviewed
Oct 11, 2020
LilyWangL
approved these changes
Oct 13, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the provided CMake file instead of the VS solutions to build the library, as recommended in the maintainer guidelines. DirectXTex can be built without DirectX12 (default for desktop) for Windows 7 Service Pack 1 or later, or with DirectX12 (default for ARM or UWP) for Windows 10.
Also add the openexr feature to enable OpenEXR format support in the library and its tools : https://github.com/Microsoft/DirectXTex/wiki/Adding-OpenEXR