[vcpkg_from_git] Add SHA512 argument, deprecate usage without argument.#13941
Closed
ras0219 wants to merge 18 commits intomicrosoft:masterfrom
Closed
[vcpkg_from_git] Add SHA512 argument, deprecate usage without argument.#13941ras0219 wants to merge 18 commits intomicrosoft:masterfrom
ras0219 wants to merge 18 commits intomicrosoft:masterfrom
Conversation
[portaudio] Fix ninja 1.9.0 issue
2 tasks
BillyONeal
approved these changes
Oct 9, 2020
23a1d40 to
f9bc44d
Compare
Cherry-picked from microsoft#13065
BillyONeal
approved these changes
Oct 12, 2020
JackBoosY
approved these changes
Oct 13, 2020
…roschuma/vcpkg_from_git
…roschuma/vcpkg_from_git
Contributor
|
@ras0219 is there anything else to be done here? |
Contributor
Author
|
No functional changes; just a matter of getting a clean build |
…roschuma/vcpkg_from_git
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…roschuma/vcpkg_from_git
…roschuma/vcpkg_from_git
…roschuma/vcpkg_from_git
…roschuma/vcpkg_from_git
Contributor
Author
|
There are additional challenges to be faced with making git.exe produce stable archives across all OSes. Marking this as draft for now until those problems are solved.
|
Contributor
|
This PR has been inactive for a long time, please reopen it if there is any progress. |
Contributor
|
Would be cool to get this in some kind so that asset caching would capture git repos too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a SHA512 argument to
vcpkg_from_git(), allowing vcpkg to verify the integrity of the intermediate archives. As part of this change, callingvcpkg_from_git()without this argument is deprecated (with a warning) and all ports usingvcpkg_from_git()have been updated to pass an appropriate SHA512.As a drive by fix, this PR also fixes portaudio's ninja 1.9.0 issue by only building one of static/shared.