Fix escaping of list items from triplets#12718
Fix escaping of list items from triplets#12718Deadpikle wants to merge 9 commits intomicrosoft:masterfrom
Conversation
e.g., if you set multiple architectures for VCPKG_OSX_ARCHITECTURES, the arguments were not escaped properly. This PR fixes that. The code from this PR was pulled from microsoft#12657 and was done entirely by @strega-nil.
|
Wondering if usage of would be better within VCPKG |
|
@Neumann-A seems reasonable |
|
pbc regression will be fixed in #12732 |
The other vcpkg_execute_required_process in build_nmake didn't have quotes, and now the quotes don't seem to be needed due to changes in vcpkg_execute_required_process.
http://www.lonesock.net/files/soil.zip is down as of writing. Use closest GitHub mirror we could find.
|
Pinging @Deadpikle for response. Is work still being done for this PR? |
|
@JackBoosY Hi. Sorry for dropping off the face of the planet in this PR. I had to do some other things for work, and I haven't been able to get back to this. I don't think I'll be able to get back to this in the near future, so either someone else needs to pick up this PR and its associated fixes (are they even necessary with other work that's been done since August? I haven't been following.) or this PR needs to be closed. Apologies for not finishing it up. I was having trouble with the CI failing on something different every time. |
|
@Deadpikle That's okay, please reopen this PR when you return to work. |
This PR fixes some escaping issues of list items that could come from triplets. e.g., if you set multiple architectures for VCPKG_OSX_ARCHITECTURES, the arguments were not escaped properly. This PR fixes that.
The code from this PR was pulled from #12657 per the discussions there and was done entirely by @strega-nil.
No closed issues.
No updates to CI. This doesn't directly affect any triplets, but in theory, it will allow you to set multiple architectures (e.g. for a macOS build) in a triplet.