[pugixml] Fix pkgconfig file#12441
Merged
ras0219-msft merged 1 commit intomicrosoft:masterfrom Jul 15, 2020
Merged
Conversation
- Add missing vcpkg_fixup_pkgconfig(), which was detected in microsoft#12151 - Fix debug POSTFIX in pugixml.pc file using pugixml-v1.10_fix_debug_pkgconfig.patch based on upstream: zeux/pugixml#363 This results in the following contents of pugixml.pc: Release: Libs: -L${libdir} -lpugixml Debug: Libs: -L${libdir} -lpugixml_d
Contributor
|
Awesome PR, thanks for also doing the legwork to get it fixed upstream! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the pull request
What does your PR fix? Fixes #
vcpkg_fixup_pkgconfig(), which was detected in[CI Rebuild] Searching for the mythic libmath.a #12151 (comment)
pugixml.pcfile usingpugixml-v1.10_fix_debug_pkgconfig.patchbased on upstream: Fix debug postfix in pkgconfig file zeux/pugixml#363
This results in the following contents of
pugixml.pc:Release:
Libs: -L${libdir} -lpugixmlDebug:
Libs: -L${libdir} -lpugixml_dWhich triplets are supported/not supported? Have you updated the CI baseline?
All official triplets are supported
Does your PR follow the maintainer guide?
Yes