[pcre2] Fix -mshstk needed with -fcf-protection#12347
Merged
ras0219-msft merged 1 commit intomicrosoft:masterfrom Jul 13, 2020
Merged
Conversation
- Fixes the following error: src/sljit/sljitConfigInternal.h:219:2: error: #error "-mshstk is needed to compile with -fcf-protection" - Upstream bug report: https://bugs.exim.org/show_bug.cgi?id=2578 - Add patch based on upstream commit: https://vcs.pcre.org/pcre2?view=revision&revision=1256 - Fixes microsoft#12343
NancyLi1013
approved these changes
Jul 10, 2020
Contributor
|
fixes the #12343 issue also for me |
8 tasks
Contributor
|
Awesome job on the PR, thanks for all the information :) Thanks @cenit for the linked issue! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the pull request
src/sljit/sljitConfigInternal.h:219:2: error:#error "-mshstk is needed to compile with -fcf-protection"https://bugs.exim.org/show_bug.cgi?id=2578
https://vcs.pcre.org/pcre2?view=revision&revision=1256
All official triplets are supported
Yes