Conversation
…araview (just a workaround)
|
The features for |
|
@NancyLi1013: The feature |
|
@Neumann-A Thanks for your update. |
|
The feature
Other features failed due to this: @Neumann-A Only on a clean environment can these features pass every time? I test these features on the repo that I cloned last week and used |
| -DVTK_INSTALL_PACKAGE_DIR=share/vtk | ||
| -DVTK_INSTALL_RUNTIME_DIR=bin | ||
| -DVTK_FORBID_DOWNLOADS=ON | ||
| -DVTK_ENABLE_REMOTE_MODULES=OFF |
There was a problem hiding this comment.
This looks like it is reducing the vtk featureset -- should this be turned into a feature?
There was a problem hiding this comment.
You were the one adding:
-DVTK_FORBID_DOWNLOADS=ON
so
-DVTK_ENABLE_REMOTE_MODULES=OFF
is already a requirement to even have a chance of making the all feature work.
Either we allow downloads or we disallow downloads and remote modules.
Comment of one of the devs to vtk remote modules: #9960 (comment)
There was a problem hiding this comment.
Thanks for the link, this LGTM
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Thanks for the great work yet again! |
|
@ras0219-msft @Neumann-A this PR broke opencv[vtk] |
|
@cenit Logs? |
|
VTK not found, that's all. |
|
VTK changed their module system completely and made it finally sane. Before that VTK was just a buggy mess. If you want some features be explicitly tested in vcpkg's CI just add test port for it. See https://github.com/microsoft/vcpkg/tree/master/scripts/test_ports I mean I also explicitly deactivated VTK in PCL due to upstream not making a lot of progress. At least OpenCV seem to be updateable to make it work. (Or people need to checkout the old VTK port and use a port-overlay.) |
(also solves the paraview issue)