[MSYS2] Disable download timeout (test)#11455
[MSYS2] Disable download timeout (test)#11455MVoz wants to merge 69 commits intomicrosoft:masterfrom MVoz:disable-download-timeout
Conversation
|
???
|
| New-ItemProperty -Path "HKLM:\SOFTWARE\Microsoft\Windows\CurrentVersion\AppModelUnlock" -Name AllowDevelopmentWithoutDevLicense -Value 1 -PropertyType DWORD -Force | ||
|
|
||
| # Disable UAC | ||
| Write-Host "Disabling UAC" |
There was a problem hiding this comment.
This doesn't do anything: the builders run as LOCAL SERVICE.
|
|
||
| Set-ItemProperty "HKLM:\SYSTEM\CurrentControlSet\Control\FileSystem" -Name "SymlinkLocalToLocalEvaluation" -Value "1" -Force | ||
|
|
||
| if( Test-Path D:\downloads\tools\msys2 ) |
There was a problem hiding this comment.
This is always false because the D drive is destroyed when a VM reboots. (It's the azure temp disk)
| if( Test-Path D:\downloads\tools\msys2 ) | ||
| { | ||
| $acl = Get-Acl D:\downloads\tools | ||
| $AccessRule = New-Object System.Security.AccessControl.FileSystemAccessRule("BUILTIN\Users","FullControl","Allow") |
There was a problem hiding this comment.
I don't believe BUILTIN\Users will affect the agents.
| $acl | Set-Acl D:\downloads\tools\msys2 | Out-Null | ||
| } | ||
|
|
||
| #Invoke-Expression -Command "icacls D:\downloads\tools\msys2 /grant BUILTIN\Users:'(OI)(CI)F' /T" -Verb |
There was a problem hiding this comment.
We shouldn't check in commented out code.
|
|
||
| Write-Host "Enable long path behavior" | ||
| # See https://docs.microsoft.com/en-us/windows/desktop/fileio/naming-a-file#maximum-path-length-limitation | ||
| Set-ItemProperty -Path "HKLM:\SYSTEM\CurrentControlSet\Control\FileSystem" -Name "LongPathsEnabled" -Value "1" -Force |
There was a problem hiding this comment.
Are there specific ports tripping over this right now? If not I'd prefer to leave this turned off because we want to discourage adding ports requiring that setting.
| # See https://docs.microsoft.com/en-us/windows/desktop/fileio/naming-a-file#maximum-path-length-limitation | ||
| Set-ItemProperty -Path "HKLM:\SYSTEM\CurrentControlSet\Control\FileSystem" -Name "LongPathsEnabled" -Value "1" -Force | ||
|
|
||
| Set-ItemProperty "HKLM:\SYSTEM\CurrentControlSet\Control\FileSystem" -Name "SymlinkLocalToLocalEvaluation" -Value "1" -Force |
There was a problem hiding this comment.
I believe this is the default? On a clean system I get:
C:\Users\billy>fsutil behavior query SymlinkEvaluation
Local to local symbolic links are enabled.
Local to remote symbolic links are enabled.
Remote to local symbolic links are disabled.
Remote to remote symbolic links are disabled.
|
That's indeed very strange, I don't know why CI didn't run on this. But given that CI keeps getting broken every time something that touches msys runs I'd prefer one of those other PRs get merged soon... |
|
@BillyONeal |
|
@voskrese Can you try: to strip off a bunch of unrelated commits? That might make Azure Pipelines less confused but I'm ot positive |
|
Looks like that got it unstuck. We'll see if this wedges the builders like everything else that's touched msys as of late |
test