Skip to content

[harfbuzz] Change build depends from freetype to freetype[core]#11082

Merged
ras0219-msft merged 1 commit intomicrosoft:masterfrom
Ghabry:harfbuzz-deps
Apr 30, 2020
Merged

[harfbuzz] Change build depends from freetype to freetype[core]#11082
ras0219-msft merged 1 commit intomicrosoft:masterfrom
Ghabry:harfbuzz-deps

Conversation

@Ghabry
Copy link
Copy Markdown
Contributor

@Ghabry Ghabry commented Apr 29, 2020

The freetype dependencies libpng and bzip2 are not required for the functionality of harfbuzz.

See the discussion under #10678 (comment)

There I believed that this is a bug in the vcpkg dependency resolution but it is actually an issue with the CONTROL file.

Ah so the bug is actually the inverse of what I thought.
Well what only matters is that the result is consistent :).

And thanks for the hint about the Build-Depends.

Changing harfbuzz to

Build-Depends: freetype[core], ragel, gettext (osx)

will give:

> vcpkg install harfbuzz[core,ucdn]
Computing installation plan...
The following packages will be built and installed:
  * bzip2[core]:x86-windows
  * freetype[bzip2,core,png]:x86-windows
    harfbuzz[core,ucdn]:x86-windows
  * libpng[core]:x86-windows
  * ragel[core]:x86-windows
  * zlib[core]:x86-windows

> vcpkg install freetype[core] harfbuzz[core,ucdn]
Computing installation plan...
The following packages will be built and installed:
    freetype[core]:x86-windows
    harfbuzz[core,ucdn]:x86-windows
  * ragel[core]:x86-windows
  * zlib[core]:x86-windows

Which is exactly what I would have expected. Thanks! :)

@Ghabry
[harfbuzz] Change build depends from freetype to freetype[core]
72a1b36 
The freetype dependencies libpng and bzip2 are not required for the functionality of harfbuzz.
@ras0219-msft ras0219-msft mentioned this pull request Apr 29, 2020
Merged
@cbezault
Copy link
Copy Markdown
Contributor

cbezault commented Apr 29, 2020

Uh all the tests aren't running but I think this can safely be merged.

@cbezault
Copy link
Copy Markdown
Contributor

cbezault commented Apr 29, 2020

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Apr 29, 2020

Azure Pipelines successfully started running 1 pipeline(s).

@BillyONeal
Copy link
Copy Markdown
Member

BillyONeal commented Apr 30, 2020

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Apr 30, 2020

Azure Pipelines successfully started running 1 pipeline(s).

@LilyWangL LilyWangL added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Apr 30, 2020
@ras0219-msft ras0219-msft merged commit e138136 into microsoft:master Apr 30, 2020
@ras0219-msft
Copy link
Copy Markdown
Contributor

ras0219-msft commented Apr 30, 2020

Thanks @Ghabry once again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@cbezault cbezault cbezault approved these changes

@ras0219-msft ras0219-msft ras0219-msft approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Ghabry @cbezault @BillyONeal @ras0219-msft @LilyWangL