Skip to content

[libqcow] Initial port#11036

Merged
strega-nil merged 2 commits intomicrosoft:masterfrom
VelocityRa:libqcow-fix
May 1, 2020
Merged

[libqcow] Initial port#11036
strega-nil merged 2 commits intomicrosoft:masterfrom
VelocityRa:libqcow-fix

Conversation

@VelocityRa
Copy link
Copy Markdown
Contributor

Fixes build in #6852.

Signed-off-by: Alexandro Sanchez Bach <alexandro@phi.nz>
@VelocityRa VelocityRa changed the title [libqcow] Add new port [libqcow] Initial port Apr 26, 2020
@VelocityRa VelocityRa marked this pull request as ready for review April 26, 2020 17:49
@LilyWangL LilyWangL requested a review from NancyLi1013 April 27, 2020 01:53
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version should be 20191221.

@VelocityRa
Copy link
Copy Markdown
Contributor Author

Done.

@VelocityRa
Copy link
Copy Markdown
Contributor Author

CI failed because of something unrelated again...

@NancyLi1013
Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@VelocityRa
Copy link
Copy Markdown
Contributor Author

All tests pass, not sure why macOS is showing as failing on GitHub.

@NancyLi1013
Copy link
Copy Markdown
Contributor

osx pipeline seems to be moved to microsoft.vcpkg (x64-osx).
So we can ignore the result on vcpkg-osx-PR-test.

@NancyLi1013 NancyLi1013 added info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. and removed waiting for response labels Apr 30, 2020
@strega-nil
Copy link
Copy Markdown
Contributor

Awesome, thanks @VelocityRa :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants