Skip to content

[nana] Revert 1 darkcacok patch nana#10936

Merged
strega-nil merged 2 commits intomicrosoft:masterfrom
Darkcacok:revert-1-Darkcacok-patch-nana
May 1, 2020
Merged

[nana] Revert 1 darkcacok patch nana#10936
strega-nil merged 2 commits intomicrosoft:masterfrom
Darkcacok:revert-1-Darkcacok-patch-nana

Conversation

@Darkcacok
Copy link
Copy Markdown
Contributor

@Darkcacok Darkcacok commented Apr 20, 2020

Describe the pull request

What does your PR fix? Fixes issue #
Build in Windows 10.

Which triplets are supported/not supported? Have you updated the CI baseline?
Supported x64-windows, in x64-linux I don't know how to fix issue with fontconfig yet.
vcpkg/installed/x64-linux/lib/libfontconfig.a(fcfreetype.c.o): undefined reference to symbol 'FT_Get_Postscript_Name'

Does your PR follow the maintainer guide?

@LilyWangL
Copy link
Copy Markdown
Contributor

LilyWangL commented Apr 21, 2020

What does this PR fix?

@LilyWangL LilyWangL self-assigned this Apr 21, 2020
@Darkcacok
Copy link
Copy Markdown
Contributor Author

Darkcacok commented Apr 21, 2020

What does this PR fix?

If we have several subfolders, then the project cannot be build because cmake ignores "if (ON)".

@Darkcacok
Copy link
Copy Markdown
Contributor Author

Darkcacok commented Apr 21, 2020

I am not good at cmake. Perhaps this can be done more elegantly.

@ras0219-msft
Copy link
Copy Markdown
Contributor

ras0219-msft commented Apr 21, 2020

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Apr 21, 2020

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@cenit
Copy link
Copy Markdown
Contributor

cenit commented Apr 23, 2020

I am not good at cmake. Perhaps this can be done more elegantly.

The problem is that your PR is empty as of now. Maybe one of the commit was unwanted?

@Darkcacok Darkcacok force-pushed the revert-1-Darkcacok-patch-nana branch from c6e3750 to e99baf8 Compare April 24, 2020 05:29
@Darkcacok
Copy link
Copy Markdown
Contributor Author

Darkcacok commented Apr 24, 2020

I am not good at cmake. Perhaps this can be done more elegantly.

The problem is that your PR is empty as of now. Maybe one of the commit was unwanted?

I'm sorry. I did not notice that I canceled the changes.

@LilyWangL LilyWangL changed the title Revert 1 darkcacok patch nana [nana] Revert 1 darkcacok patch nana Apr 24, 2020
@LilyWangL
Copy link
Copy Markdown
Contributor

LilyWangL commented Apr 24, 2020

Thanks for your PR! Can you please correct the Version field in the CONTROL file? You can get more information from maintainer-guide.md.

@Darkcacok Darkcacok force-pushed the revert-1-Darkcacok-patch-nana branch from e99baf8 to 0fc3ee8 Compare April 24, 2020 12:35
@msftclas
Copy link
Copy Markdown

msftclas commented Apr 24, 2020 •
edited
Loading

CLA assistant check
All CLA requirements met.

@Darkcacok
Copy link
Copy Markdown
Contributor Author

Darkcacok commented Apr 24, 2020

done

@LilyWangL LilyWangL added info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. and removed waiting for response labels Apr 26, 2020
@strega-nil
Copy link
Copy Markdown
Contributor

strega-nil commented May 1, 2020

Alright, LGTM! Thanks @Darkcacok :)

@strega-nil strega-nil merged commit e845327 into microsoft:master May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@LilyWangL LilyWangL

Labels

info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Darkcacok @LilyWangL @ras0219-msft @cenit @msftclas @strega-nil