[vcpkg] Improve make builds#10402
Conversation
|
Thanks @Neumann-A ! |
|
hmm some of those build failures I am unable to reproduce locally
wrong subpaths |
|
@ras0219-msft: Please tell us how to deal with the compiler flags in the different |
This reverts commit 9c9851d.
working test MSVC |
|
not work code, script configure work MSVC test |
|
@dan-shaw |
|
REGRESSION:
|
|
had a good start, it would have been good to finish and combine/merge |
Co-authored-by: Jack·Boos·Yu <47264268+JackBoosY@users.noreply.github.com>
|
Ping @strega-nil for review this PR. |
|
Alright, thanks so much @Neumann-A, this is incredible! |
|
This PR changed the pkg-config configuration from using I'm asking because I see a compilation error for GDAL on Linux related to OpenEXR. OpenEXR seems to be installed in the Linux image (Azure pipelines), as it is found via pkg-config by GDAL, but not a dependency in vcpkg. There may be an insufficient configuration test on the gdal side (it tests linking, but not including headers). On the vcpkg side, IIUC the consequence of I suppose what is desired is that .pc files, includes and libraries are used from vcpkg only, similar to cross-compilation contexts. In my experience, this requires setting |
|
@dg0yt at the time vcpkg_configure_make was not really useable on any platform. Pc files were not corrected and the prefix was a hardcoded absolute path. The --define-variable was introduced before $(pcfiledir) was known about and integrated into vcpkg_fixup_pkgconfig. Before that the prefix variable was completly removed which made setting it a requirement. If it is still in vcpkg_configure_make and creating problems just remove it. It is no longer necessary |
|
@Neumann-A Thank you. I will try without. Looking forward to test with Android triplets soon. |
Trying to correctly fix make builds for msvc
related to #9966 (main logic to make msvc builds work are taken from there)