Add ability to pass global agent options for HttpClient#378
Merged
aleksandrlevochkin merged 3 commits intoSep 19, 2024
Conversation
kirill-ivlev
approved these changes
Sep 19, 2024
DergachevE
approved these changes
Sep 19, 2024
DmitriiBobreshev
approved these changes
Sep 19, 2024
2 tasks
|
@aleksandrlevochkin you created a new package release by merging this pull request. Please push a tag. The problem of inconsistency of tagging by the project maintainers has been reported several times, including #361. Please reopen that issue until you have established a system that will ensure there is a tag for every Git release. |
Contributor
Author
|
@per1234 thank you, I created a tag and a release for v2.1.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WI
AB#2212397
Description
Since Node 19 global http agent uses HTTP Keep-Alive and a 5 second timeout by default: https://nodejs.org/api/http.html#httpglobalagent.
This might cause issues like this one with
UseDotNettask: microsoft/azure-pipelines-tasks#20396I added
globalAgentOptionsproperty toIRequestOptionsto be able to settimeoutandkeepAliveparameters for global agent as needed when usingHttpClient.