Explicitly define exports for npm package, closes #134#163
Closed
RVledder wants to merge 2 commits intomicrosoft:mainfrom
RVledder:fix/gh-134-export-pattern
Closed
Explicitly define exports for npm package, closes #134#163RVledder wants to merge 2 commits intomicrosoft:mainfrom RVledder:fix/gh-134-export-pattern
RVledder wants to merge 2 commits intomicrosoft:mainfrom
RVledder:fix/gh-134-export-pattern
Conversation
added 2 commits
November 24, 2021 14:07
Signed-off-by: remivledder <remi.vledder@powerhouse.nl>
Signed-off-by: remivledder <remi.vledder@powerhouse.nl>
Author
|
Using the test script by @rbuckton in this comment:
NOTES: |
|
Hopefully this works! |
Author
|
So... Is this library still maintained? |
|
@rbuckton @DanielRosenwasser @orta could you give us a hand getting this merged? Maybe point us in the right direction of who could/should review and approve it? |
Contributor
|
I merged #135, so this is no longer needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tried it out in a local project and it works. But that's a specific implementation. Also, the tests are green.
Would be interested in any thoughts of a repository maintainer. More info in #134