Merged
Conversation
Evangelink
approved these changes
Mar 10, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Removes two unused serializer-related localized resource strings and simplifies the IPC serializer lookup implementation in NamedPipeBase.
Changes:
- Deleted
NoSerializerRegisteredWithIdErrorMessage/NoSerializerRegisteredWithTypeErrorMessageentries fromPlatformResources.resxand all corresponding.xlftranslations. - Removed the generated resource accessors for those keys from
PlatformResources.cs. - Simplified
NamedPipeBase.GetSerializer(...)to use direct dictionary indexing.
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.zh-Hant.xlf | Removed translation units for deleted serializer error messages. |
| src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.zh-Hans.xlf | Removed translation units for deleted serializer error messages. |
| src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.tr.xlf | Removed translation units for deleted serializer error messages. |
| src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.ru.xlf | Removed translation units for deleted serializer error messages. |
| src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.pt-BR.xlf | Removed translation units for deleted serializer error messages. |
| src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.pl.xlf | Removed translation units for deleted serializer error messages. |
| src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.ko.xlf | Removed translation units for deleted serializer error messages. |
| src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.ja.xlf | Removed translation units for deleted serializer error messages. |
| src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.it.xlf | Removed translation units for deleted serializer error messages. |
| src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.fr.xlf | Removed translation units for deleted serializer error messages. |
| src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.es.xlf | Removed translation units for deleted serializer error messages. |
| src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.de.xlf | Removed translation units for deleted serializer error messages. |
| src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.cs.xlf | Removed translation units for deleted serializer error messages. |
| src/Platform/Microsoft.Testing.Platform/Resources/PlatformResources.resx | Removed the two serializer error message resource entries. |
| src/Platform/Microsoft.Testing.Platform/Resources/PlatformResources.cs | Removed the two resource accessor properties for the deleted keys. |
| src/Platform/Microsoft.Testing.Platform/IPC/NamedPipeBase.cs | Changed serializer lookup to dictionary indexer (affects exception type/message on missing serializer). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't need to throw our own InvalidOperationException here for case that should never be hit in practice. Instead, we can let the dictionary implementation throws KeyNotFoundException which will have the same amount of information as our exception.