Move InvalidTestApplicationBuilderTypeForAI from MTP to MTP.AI#7517
Merged
Evangelink merged 1 commit intomainfrom Mar 10, 2026
Merged
Move InvalidTestApplicationBuilderTypeForAI from MTP to MTP.AI#7517Evangelink merged 1 commit intomainfrom
Evangelink merged 1 commit intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Moves the InvalidTestApplicationBuilderTypeForAI localized string out of the core Microsoft.Testing.Platform resources and into the Microsoft.Testing.Platform.AI extension resources, so the AI package owns its own user-facing messages.
Changes:
- Removed
InvalidTestApplicationBuilderTypeForAIfromPlatformResources.resx,PlatformResources.cs, and the Platform.xlflocalization files. - Added
AIExtensionResources.resxplus per-locale.xlffiles inMicrosoft.Testing.Platform.AI. - Updated
ChatClientProviderExtensionsto throw usingAIExtensionResources.InvalidTestApplicationBuilderTypeForAIand removed the linkedPlatformResources.csinclude from the AI project.
Reviewed changes
Copilot reviewed 31 out of 31 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/Platform/Microsoft.Testing.Platform/Resources/PlatformResources.resx | Removes the AI-specific resource entry from core platform resources. |
| src/Platform/Microsoft.Testing.Platform/Resources/PlatformResources.cs | Removes the strongly-typed accessor for the removed resource. |
| src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.*.xlf | Drops the corresponding translation units from platform localization files. |
| src/Platform/Microsoft.Testing.Platform.AI/Resources/AIExtensionResources.resx | Introduces the AI extension-owned resource entry. |
| src/Platform/Microsoft.Testing.Platform.AI/Resources/xlf/AIExtensionResources.*.xlf | Adds locale files for the AI extension resource. |
| src/Platform/Microsoft.Testing.Platform.AI/Microsoft.Testing.Platform.AI.csproj | Stops linking core PlatformResources.cs into the AI project and adjusts package properties. |
| src/Platform/Microsoft.Testing.Platform.AI/ChatClientProviderExtensions.cs | Switches the thrown error message to the AI resource class/namespace. |
src/Platform/Microsoft.Testing.Platform.AI/ChatClientProviderExtensions.cs
Show resolved
Hide resolved
Evangelink
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.