Fix FP with proper assert analyzer and IComparable#7405
Merged
Evangelink merged 2 commits intomainfrom Feb 16, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a false positive in the UseProperAssertMethodsAnalyzer where it would incorrectly suggest using Assert.IsGreaterThan and similar comparison methods for types that don't implement IComparable<T>, specifically nullable value types like TimeSpan?.
Changes:
- Added IComparable validation before suggesting comparison assert methods
- Added test case for nullable value type comparisons
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Analyzers/MSTest.Analyzers/UseProperAssertMethodsAnalyzer.cs | Added CanUseTypesWithComparableAsserts and related helper methods to validate types implement IComparable before suggesting comparison assert methods |
| test/UnitTests/MSTest.Analyzers.UnitTests/UseProperAssertMethodsAnalyzerTests.cs | Added test to verify nullable value types don't trigger comparison assert suggestions |
Youssef1313
reviewed
Feb 14, 2026
src/Analyzers/MSTest.Analyzers/UseProperAssertMethodsAnalyzer.cs
Outdated
Show resolved
Hide resolved
Youssef1313
reviewed
Feb 14, 2026
src/Analyzers/MSTest.Analyzers/UseProperAssertMethodsAnalyzer.cs
Outdated
Show resolved
Hide resolved
Youssef1313
reviewed
Feb 14, 2026
src/Analyzers/MSTest.Analyzers/UseProperAssertMethodsAnalyzer.cs
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #7343