Fix TypeCache to throw on duplicate attributes when necessary#7223
Merged
Youssef1313 merged 4 commits intomainfrom Jan 15, 2026
Merged
Fix TypeCache to throw on duplicate attributes when necessary#7223Youssef1313 merged 4 commits intomainfrom
Youssef1313 merged 4 commits intomainfrom
Conversation
Member
Author
|
@copilot Please add an MSTest acceptance test for this scneario: [TestClass]
public class TestClass1
{
[TestMethod]
[MyTestMethod]
public void Test1()
{
}
[TestMethod]
public void Test2()
{
}
}
[TestClass]
[MyTestClass]
public class TestClass2
{
[TestMethod]
public void Test1()
{
}
}
public class MyTestMethodAttribute : TestMethodAttribute
{
public MyTestMethodAttribute([CallerFilePath] string callerFilePath = "", [CallerLineNumber] int callerLineNumber = -1)
: base(callerFilePath, callerLineNumber)
{
}
}
public class MyTestClass : TestClassAttribute
{
} |
Contributor
|
@Youssef1313 I've opened a new pull request, #7224, to work on those changes. Once the pull request is ready, I'll request review from you. |
Youssef1313
commented
Jan 14, 2026
#7224) Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Youssef1313 <31348972+Youssef1313@users.noreply.github.com> Co-authored-by: Youssef Victor <youssefvictor00@gmail.com>
fhnaseer
approved these changes
Jan 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4333