Add UseSTASynchronizationContext to STATestMethod#7192
Merged
Evangelink merged 5 commits intomainfrom Jan 14, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a UseSTASynchronizationContext property to STATestMethodAttribute to enable preserving the STA thread context for async continuations. When enabled, the attribute creates a custom SynchronizationContext that ensures async continuations run on the same STA thread, which is useful for testing UI components that require STA threading.
Changes:
- Introduced
SingleThreadedSTASynchronizationContextclass that manages a dedicated STA thread and routes all operations to it - Added
UseSTASynchronizationContextproperty toSTATestMethodAttributewith default value offalse - Modified
STATestMethodAttribute.ExecuteAsyncto conditionally use the new synchronization context - Added tests to verify both default behavior (no sync context) and new behavior (with sync context)
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/TestFramework/TestFramework/Attributes/TestMethod/SingleThreadedSTASynchronizationContext.cs |
New internal class that implements a custom SynchronizationContext with a dedicated STA thread for routing operations |
src/TestFramework/TestFramework/Attributes/TestMethod/STATestMethodAttribute.cs |
Added UseSTASynchronizationContext property and modified ExecuteAsync to optionally use the new sync context |
src/TestFramework/TestFramework/PublicAPI/PublicAPI.Unshipped.txt |
Added public API entries for the new property getter and setter |
test/UnitTests/MSTest.SelfRealExamples.UnitTests/STATestMethodSyncContext.cs |
Added integration tests verifying both default and new behavior |
src/TestFramework/TestFramework/Attributes/TestMethod/STATestMethodAttribute.cs
Show resolved
Hide resolved
...TestFramework/TestFramework/Attributes/TestMethod/SingleThreadedSTASynchronizationContext.cs
Show resolved
Hide resolved
...TestFramework/TestFramework/Attributes/TestMethod/SingleThreadedSTASynchronizationContext.cs
Show resolved
Hide resolved
...TestFramework/TestFramework/Attributes/TestMethod/SingleThreadedSTASynchronizationContext.cs
Show resolved
Hide resolved
src/TestFramework/TestFramework/Attributes/TestMethod/STATestMethodAttribute.cs
Show resolved
Hide resolved
src/TestFramework/TestFramework/Attributes/TestMethod/STATestMethodAttribute.cs
Show resolved
Hide resolved
nohwnd
approved these changes
Jan 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5729