Merged
Conversation
Youssef1313
reviewed
Sep 3, 2025
Youssef1313
approved these changes
Sep 3, 2025
Member
|
Would you reconsider the name to be --debug? That is what dotnet sdk uses, even though they just emit it in debug builds. https://github.com/dotnet/sdk/blob/main/src/Cli/dotnet/Extensions/ParseResultExtensions.cs#L232-L239 --debug:attach is used just by templating engine. Also the I've grown to like the implementation on msbuild that does readline, and unblocks even if there is no debugger. Makes it nicer when you run with the parameter / env variable by accident and just want to continue. On the other hand, it is annoying to have to press the key to unblock, so imho awaiting the debugger or keypress would be the best. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5531
I went with
--debug-attachas it seems more natural and closer to reality than--debugto me. This is also aligned with naming on sdk --debug: attachAnother option would be to use
--debug attachso we could add more debug modes in the future.