Implement analyzer for TestMethodAttribute inheritance #6405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
65 tasks
nohwnd
reviewed
Aug 19, 2025
Member
nohwnd
left a comment
There was a problem hiding this comment.
Looks great. Out of curiosity, is there some way that the user won't have the attributes available but would still be able to use mstest v4? (e.g. using an old language verison, outdated compiler that still can compile our minimal TFM, or something similar).
...yzers/MSTest.Analyzers.CodeFixes/TestMethodAttributeShouldPropagateSourceInformationFixer.cs
Outdated
Show resolved
Hide resolved
Member
Author
The attributes are available in all our supported target frameworks. We don't use any polyfills for them in the base |
…ouldPropagateSourceInformationFixer.cs
Evangelink
approved these changes
Aug 20, 2025
Member
Evangelink
left a comment
There was a problem hiding this comment.
LGTM - it could be good to add one more test with caller file path defined after caller line number just to ensure we don't rely on their order (maybe even with another optional parameter in between).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1285